Support "trace" log level [v8]#3526
Closed
marckhouzam wants to merge 1 commit intocloudfoundry:v8from
Closed
Conversation
The "logrus" library supports a "trace=6" log level, but the CLI does not accept the "trace" word for this level. Signed-off-by: Marc Khouzam <marc.khouzam@broadcom.com>
|
Contributor
Author
|
It was brought up that using the word |
Member
|
@marckhouzam can we close this if not needed now? |
Contributor
Author
|
OK, let’s close for the moment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR allows to use the
tracekeyword to set a log level, as supported by the "logrus" library as seen here https://github.com/sirupsen/logrus/blob/d1e6332644483cfee14de11099f03645561d55f8/logrus.go#L111The PR takes the approach of parsing log levels using a "logrus" library function instead of duplicating the code locally.
Why Is This PR Valuable?
It allow to use
CF_LOGL_LEVEL=tracewhen debugging, which is supported by the log library.It would also open the door to the CLI code to use
log.Trace()for an extra level of logs.Applicable Issues
Fixes #3525
How Urgent Is The Change?
Not urgent.