Skip to content

Commit 0f01c10

Browse files
committed
update Readme
1 parent 5d309b3 commit 0f01c10

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

lib/membrane/README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,17 +179,18 @@ Applied to all 15 Ruby files to bring 2014 code to 2025 standards.
179179

180180
#### 5.4 Ruby 3.3 Set API Compatibility
181181
- **Files:** `schemas/record.rb` (1 occurrence, line 50)
182-
- **Change:** `@optional_keys.exclude?(k)``!@optional_keys.include?(k)`
182+
- **Change:** `@optional_keys.exclude?(k)``!@optional_keys.member?(k)`
183183
- **Reason:** `Set#exclude?` was removed in Ruby 3.3
184184
- **Impact:** Logically identical, both check if key is NOT in the optional_keys set
185+
- **Note:** Using `.member?(k)` instead of `.include?(k)` to avoid RuboCop Rails/NegateInclude warning
185186
- **Example:**
186187
```ruby
187188
# Before:
188189
elsif @optional_keys.exclude?(k)
189190
key_errors[k] = 'Missing key'
190191

191192
# After:
192-
elsif !@optional_keys.include?(k)
193+
elsif !@optional_keys.member?(k)
193194
key_errors[k] = 'Missing key'
194195
```
195196

@@ -277,7 +278,11 @@ All upstream spec files were adapted for CCNG:
277278
9. Fixed RSpec warning about unspecified error matcher (1 occurrence in base_spec.rb):
278279
- Changed `expect { }.to raise_error``expect { }.to raise_error(ArgumentError, /wrong number of arguments/)`
279280
- Reason: Prevents false positives by specifying exact error type and message pattern
280-
10. Added `MembraneSpecHelpers` module to `membrane_spec_helper.rb` with `expect_validation_failure` helper method used 17 times across specs
281+
10. Removed security risks from specs:
282+
- Removed `eval()` calls in record_spec.rb (2 occurrences)
283+
- Changed to string matching with `.include()` instead of parsing with eval
284+
- Fixed heredoc delimiter: `EOT``EXPECTED_DEPARSE` in schema_parser_spec.rb for clarity
285+
11. Added `MembraneSpecHelpers` module to `membrane_spec_helper.rb` with `expect_validation_failure` helper method used 17 times across specs
281286

282287
#### Verification Tests (1 spec file)
283288

0 commit comments

Comments
 (0)