Fix RuboCop offenses in domain_create_message and route_policies_list_message_spec

Author: rkoster

app/messages/domain_create_message.rb

@@ -88,17 +88,29 @@ def alpha_numeric
     end
 
     def mutually_exclusive_fields
-      errors.add(:base, 'Cannot associate an internal domain with an organization') if requested?(:internal) && internal == true && requested?(:relationships)
-      errors.add(:base, 'Internal domains cannot be associated to a router group.') if requested?(:internal) && internal == true && requested?(:router_group)
-      errors.add(:base, 'Internal domains cannot have route policy enforcement. Internal routes bypass GoRouter.') if requested?(:internal) && internal == true &&
-                                                                                                                      requested?(:enforce_route_policies) && enforce_route_policies == true
-      errors.add(:base, 'Domains with a router group cannot have route policy enforcement. TCP routes do not support mTLS policy enforcement.') if requested?(:router_group) &&
-                                                                                                                                                   requested?(:enforce_route_policies) && enforce_route_policies == true
+      validate_internal_domain_exclusions
+      validate_router_group_exclusions
       return unless requested?(:relationships) && requested?(:router_group)
 
       errors.add(:base, 'Domains scoped to an organization cannot be associated to a router group.')
     end
 
+    def validate_internal_domain_exclusions
+      return unless requested?(:internal) && internal == true
+
+      errors.add(:base, 'Cannot associate an internal domain with an organization') if requested?(:relationships)
+      errors.add(:base, 'Internal domains cannot be associated to a router group.') if requested?(:router_group)
+      return unless requested?(:enforce_route_policies) && enforce_route_policies == true
+
+      errors.add(:base, 'Internal domains cannot have route policy enforcement. Internal routes bypass GoRouter.')
+    end
+
+    def validate_router_group_exclusions
+      return unless requested?(:router_group) && requested?(:enforce_route_policies) && enforce_route_policies == true
+
+      errors.add(:base, 'Domains with a router group cannot have route policy enforcement. TCP routes do not support mTLS policy enforcement.')
+    end
+
     def router_group_validation
       return if router_group.nil?
       return errors.add(:router_group, 'must be an object') unless router_group.is_a?(Hash)

spec/unit/messages/route_policies_list_message_spec.rb

@@ -59,7 +59,7 @@ module VCAP::CloudController
           page: 1,
           per_page: 5,
           order_by: 'created_at',
-                                                 include: %w[source route]
+          include: %w[source route]
         }
       end
 
@@ -81,7 +81,7 @@ module VCAP::CloudController
                                                  page: 1,
                                                  per_page: 5,
                                                  order_by: 'created_at',
-          include: %w[source route]
+                                                 include: %w[source route]
                                                })
         end.not_to raise_error
       end