Some test fixes and cleanup

Author: hoffmaen

app/actions/manifest_route_update.rb

@@ -95,8 +95,6 @@ def find_or_create_valid_route(app, manifest_route, user_audit_info)
           elsif !route.available_in_space?(app.space)
             raise InvalidRoute.new('Routes cannot be mapped to destinations in different spaces')
           elsif manifest_route[:options]
-            # remove nil values from options
-            manifest_route[:options] = manifest_route[:options].compact
             message = RouteUpdateMessage.new({
                                                'options' => manifest_route[:options]
                                              })

app/actions/route_create.rb

@@ -20,7 +20,7 @@ def create(message:, space:, domain:, manifest_triggered: false)
       )
 
       Route.db.transaction do
-        route.save(raise_on_failure: true)
+        route.save
 
         MetadataUpdate.update(route, message)
       end

app/actions/route_update.rb

@@ -6,8 +6,8 @@ class Error < StandardError
     def update(route:, message:)
 
       Route.db.transaction do
-        route.options = route.options.symbolize_keys.merge(message.options).compact if message.requested?(:options)
-        route.save(raise_on_failure: true)
+        route.options = route.options.symbolize_keys.merge(message.options) if message.requested?(:options)
+        route.save
         MetadataUpdate.update(route, message)
       end
 

app/models/runtime/route.rb

@@ -78,6 +78,8 @@ def options_with_serialization=(opts)
       cleaned_opts = remove_hash_options_for_non_hash_loadbalancing(opts)
       rounded_opts = round_hash_balance_to_one_decimal(cleaned_opts)
       normalized_opts = normalize_hash_balance_to_string(rounded_opts)
+      # Remove nil values after all processing
+      normalized_opts = normalized_opts.compact if normalized_opts.is_a?(Hash)
       self.options_without_serialization = Oj.dump(normalized_opts)
 
       logger.error("CRITICAL: options_with_serialization= setter completed", normalized_opts: normalized_opts.inspect, json: self.options_without_serialization.inspect)
@@ -330,7 +332,7 @@ def validate_total_reserved_route_ports
     def validate_route_options
       return if options.blank?
 
-      route_options = options.is_a?(Hash) ? options : options.deep_symbolize_keys
+      route_options = options.is_a?(Hash) ? options : options.symbolize_keys
       loadbalancing = route_options[:loadbalancing] || route_options['loadbalancing']
 
       return if loadbalancing != 'hash'

spec/unit/messages/validators_spec.rb

@@ -708,7 +708,7 @@ def self.enabled?(flag_name, **)
         it 'does not allow hash_balance between 0 and 1.1' do
           message = OptionsMessage.new({ options: { hash_balance: 0.5 } })
           expect(message).not_to be_valid
-          expect(message.errors.full_messages).to include('Options Hash balance must be either 0 or greater than or equal to 1.1')
+          expect(message.errors.full_messages).to include('Options Hash balance must be either 0 or between 1.1 and 10.0')
         end
 
         it 'allows numeric string hash_balance' do