Commit 35881c9
authored
Remove unnecessary explicit adapter requires from monkeypatch (#5086)
The sequel_case_insensitive_string_monkeypatch unconditionally required
sequel/adapters/postgres and sequel/adapters/mysql2, even though the
file is only ever loaded via DBMigrator.apply_migrations after a DB
connection is already established (which auto-loads the adapter).
Replace the explicit requires with `defined?` guards so each adapter is
only patched when actually in use. This avoids loading cross-adapter
code unnecessarily and makes tests that reference adapter-specific
constants (like Sequel::Postgres::Dataset) fail visibly when the adapter
is not loaded, rather than being silently masked.1 parent 143fa87 commit 35881c9
1 file changed
Lines changed: 17 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | 2 | | |
5 | 3 | | |
6 | 4 | | |
| |||
26 | 24 | | |
27 | 25 | | |
28 | 26 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
33 | 32 | | |
34 | | - | |
35 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
44 | 45 | | |
45 | | - | |
46 | | - | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
0 commit comments