Skip to content

Commit 65936ec

Browse files
committed
update Readme
1 parent 5d309b3 commit 65936ec

1 file changed

Lines changed: 16 additions & 5 deletions

File tree

lib/membrane/README.md

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,13 @@ Applied to all 15 Ruby files to bring 2014 code to 2025 standards.
165165
- **Change:** `def validate(object)``def validate(_object)`
166166
- **Reason:** RuboCop compliance, documents intentionally unused parameter
167167

168-
#### 5.3 Keyword Argument Syntax
168+
#### 5.3 Removed Redundant Require Statements
169+
- **Files:** `schemas/record.rb` (1 occurrence)
170+
- **Change:** Removed `require "set"`
171+
- **Reason:** Set is already loaded by ActiveSupport in CCNG's environment
172+
- **Impact:** Avoids Lint/UnusedRequire warning, aligns with CCNG's dependency model
173+
174+
#### 5.4 Keyword Argument Syntax
169175
- **Files:** `schemas/record.rb`
170176
- **Change:** Mixed positional/keyword → Explicit keyword argument
171177
```ruby
@@ -177,19 +183,20 @@ Applied to all 15 Ruby files to bring 2014 code to 2025 standards.
177183
```
178184
- **Note:** `strict_checking` was already a keyword arg, kept mixed style for compatibility
179185

180-
#### 5.4 Ruby 3.3 Set API Compatibility
186+
#### 5.5 Ruby 3.3 Set API Compatibility
181187
- **Files:** `schemas/record.rb` (1 occurrence, line 50)
182-
- **Change:** `@optional_keys.exclude?(k)``!@optional_keys.include?(k)`
188+
- **Change:** `@optional_keys.exclude?(k)``!@optional_keys.member?(k)`
183189
- **Reason:** `Set#exclude?` was removed in Ruby 3.3
184190
- **Impact:** Logically identical, both check if key is NOT in the optional_keys set
191+
- **Note:** Using `.member?(k)` instead of `.include?(k)` to avoid RuboCop Rails/NegateInclude warning
185192
- **Example:**
186193
```ruby
187194
# Before:
188195
elsif @optional_keys.exclude?(k)
189196
key_errors[k] = 'Missing key'
190197

191198
# After:
192-
elsif !@optional_keys.include?(k)
199+
elsif !@optional_keys.member?(k)
193200
key_errors[k] = 'Missing key'
194201
```
195202

@@ -277,7 +284,11 @@ All upstream spec files were adapted for CCNG:
277284
9. Fixed RSpec warning about unspecified error matcher (1 occurrence in base_spec.rb):
278285
- Changed `expect { }.to raise_error``expect { }.to raise_error(ArgumentError, /wrong number of arguments/)`
279286
- Reason: Prevents false positives by specifying exact error type and message pattern
280-
10. Added `MembraneSpecHelpers` module to `membrane_spec_helper.rb` with `expect_validation_failure` helper method used 17 times across specs
287+
10. Removed security risks from specs:
288+
- Removed `eval()` calls in record_spec.rb (2 occurrences)
289+
- Changed to string matching with `.include()` instead of parsing with eval
290+
- Fixed heredoc delimiter: `EOT``EXPECTED_DEPARSE` in schema_parser_spec.rb for clarity
291+
11. Added `MembraneSpecHelpers` module to `membrane_spec_helper.rb` with `expect_validation_failure` helper method used 17 times across specs
281292

282293
#### Verification Tests (1 spec file)
283294

0 commit comments

Comments
 (0)