Added warning for restaging app on restricted stack

Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>

Author: rashedkvm

lib/cloud_controller/stack_state_validator.rb

@@ -10,22 +10,26 @@ def self.validate_for_new_app!(stack)
 
       raise RestrictedStackError.new(build_stack_error(stack, StackStates::STACK_RESTRICTED)) if stack.restricted?
 
-      stack.deprecated? ? [build_deprecation_warning(stack, StackStates::STACK_DEPRECATED)] : []
+      stack.deprecated? ? [build_stack_warning(stack, StackStates::STACK_DEPRECATED)] : []
     end
 
     def self.validate_for_restaging!(stack)
-      return [] if stack.active? || stack.restricted?
+      return [] if stack.active?
+
+      return [build_stack_warning(stack, StackStates::STACK_RESTRICTED)] if stack.restricted?
+
+      return [build_stack_warning(stack, StackStates::STACK_DEPRECATED)] if stack.deprecated?
 
       raise DisabledStackError.new(build_stack_error(stack, StackStates::STACK_DISABLED)) if stack.disabled?
 
-      stack.deprecated? ? [build_deprecation_warning(stack, StackStates::STACK_DEPRECATED)] : []
+      []
     end
 
     def self.build_stack_error(stack, state)
       "ERROR: Staging failed. The stack '#{stack.name}' is '#{state}' and cannot be used for staging."
     end
 
-    def self.build_deprecation_warning(stack, state)
+    def self.build_stack_warning(stack, state)
       "WARNING: The stack '#{stack.name}' is '#{state}' and will be removed in the future."
     end
   end

spec/request/v2/apps_spec.rb

@@ -1763,10 +1763,10 @@ def make_actual_lrp(instance_guid:, index:, state:, error:, since:)
             expect(last_response.status).to eq(201)
           end
 
-          it 'does not include warnings header' do
+          it 'includes warning in header' do
             post "/v2/apps/#{process.guid}/restage", nil, headers_for(user)
 
-            expect(last_response.headers['X-Cf-Warnings']).to be_nil
+            expect(last_response.headers['X-Cf-Warnings']).not_to be_nil
           end
         end
       end

spec/unit/actions/v2/app_stage_spec.rb

@@ -302,9 +302,9 @@ module V2
                 BuildModel.make(app: process.app, state: 'STAGED')
               end
 
-              it 'allows staging without warnings' do
+              it 'allows staging with warnings' do
                 expect { action.stage(process) }.not_to raise_error
-                expect(action.warnings).to be_empty
+                expect(action.warnings).not_to be_empty
               end
             end
           end

spec/unit/lib/cloud_controller/stack_state_validator_spec.rb

@@ -116,9 +116,11 @@ module VCAP::CloudController
       context 'when stack is RESTRICTED' do
         let(:stack) { Stack.make(state: StackStates::STACK_RESTRICTED, description: 'My RESTRICTED stack') }
 
-        it 'returns empty warnings' do
+        it 'returns warnings for restaging' do
           result = StackStateValidator.validate_for_restaging!(stack)
-          expect(result).to eq([])
+          warning = result.first
+          expect(warning).to include(stack.name)
+          expect(warning).to include('RESTRICTED')
         end
 
         it 'does not raise an error' do
@@ -147,21 +149,21 @@ module VCAP::CloudController
       let(:stack) { Stack.make(name: 'cflinuxfs3', description: 'End of life December 2025') }
 
       it 'returns formatted warning string' do
-        warning = StackStateValidator.build_deprecation_warning(stack, StackStates::STACK_DEPRECATED)
+        warning = StackStateValidator.build_stack_warning(stack, StackStates::STACK_DEPRECATED)
         expect(warning).to be_a(String)
         expect(warning).to include('cflinuxfs3')
         expect(warning).to include('DEPRECATED')
       end
 
       it 'includes stack name when description is empty' do
         stack.description = ''
-        warning = StackStateValidator.build_deprecation_warning(stack, StackStates::STACK_DEPRECATED)
+        warning = StackStateValidator.build_stack_warning(stack, StackStates::STACK_DEPRECATED)
         expect(warning).to include('cflinuxfs3')
       end
 
       it 'handles nil description' do
         stack.description = nil
-        warning = StackStateValidator.build_deprecation_warning(stack, StackStates::STACK_DEPRECATED)
+        warning = StackStateValidator.build_stack_warning(stack, StackStates::STACK_DEPRECATED)
         expect(warning).to include('cflinuxfs3')
       end
     end
@@ -205,7 +207,7 @@ module VCAP::CloudController
 
         it 'allows RESTRICTED without warnings' do
           result = StackStateValidator.validate_for_restaging!(restricted_stack)
-          expect(result).to be_empty
+          expect(result).not_to be_empty
         end
 
         it 'rejects DISABLED' do