Fix LrpStateTranslator: Add STOPPING state

Author: jochenehret

lib/cloud_controller/diego/reporters/instances_reporter.rb

@@ -146,6 +146,8 @@ def self.translate_lrp_state(lrp)
           lrp.placement_error.present? ? VCAP::CloudController::Diego::LRP_DOWN : VCAP::CloudController::Diego::LRP_STARTING
         when ::Diego::ActualLRPState::CRASHED
           VCAP::CloudController::Diego::LRP_CRASHED
+        when ::Diego::ActualLRPState::STOPPING
+          VCAP::CloudController::Diego::LRP_STOPPING
         else
           VCAP::CloudController::Diego::LRP_UNKNOWN
         end

lib/diego/lrp_constants.rb

@@ -4,5 +4,6 @@ module ActualLRPState
     CLAIMED   = 'CLAIMED'.freeze
     RUNNING   = 'RUNNING'.freeze
     CRASHED   = 'CRASHED'.freeze
+    STOPPING  = 'STOPPING'.freeze
   end
 end

spec/unit/lib/cloud_controller/diego/reporters/instances_reporter_spec.rb

@@ -453,6 +453,24 @@ def make_actual_lrp(instance_guid:, index:, state:, error:, since:, routable: ni
             end
           end
         end
+
+        context 'when an LRP is STOPPING' do
+          let(:desired_instances) { 1 }
+          let(:bbs_instances_response) do
+            [
+              make_actual_lrp(instance_guid: 'instance-a', index: 0, state: ::Diego::ActualLRPState::STOPPING, error: '', since: two_days_ago_since_epoch_ns)
+            ]
+          end
+
+          before do
+            allow(bbs_instances_client).to receive(:lrp_instances).with(process).and_return(bbs_instances_response)
+          end
+
+          it 'translates STOPPING to STOPPING' do
+            result = instances_reporter.all_instances_for_app(process)
+            expect(result[0][:state]).to eq(VCAP::CloudController::Diego::LRP_STOPPING)
+          end
+        end
       end
 
       describe '#instance_count_summary' do