Integrate steno logging library directly into cloud_controller_ng

This integrates the steno logging library as an internal component rather
than an external gem dependency, allowing for better control, customization,
and maintainability within the Cloud Controller codebase.

Key Changes:
- Integrated steno library code from cloudfoundry/steno repository
- Removed steno gem dependency from Gemfile
- Flattened steno directory structure under lib/steno/
- Removed unused steno features (Windows support, context providers, tagged logging)
- Updated all require paths from 'steno' to 'steno/steno'
- Removed lib/steno.rb wrapper file

Steno Modifications:
- Replaced Yajl with Oj JSON parser for better performance
- Added syslog gem dependency for syslog sink functionality
- Removed unused yajl-ruby gem
- Applied RuboCop auto-corrections to integrated steno code
- Integrated custom RFC3339 codec (lib/steno/codec/codec_rfc3339.rb)
- Documented modification policy in README.md

Bug Fixes:
- Fixed race condition in syslog reset for parallel test execution
- Added reset! method to Syslog singleton for proper test cleanup
- Added nil guard to syslog sink add_record method
- Fixed syslog sink mock leakage between tests
- Fixed steno JSON codec timestamp test to accept Numeric types

Test Infrastructure:
- Moved steno tests to spec/isolated_specs/steno/ to prevent mock leakage
- Restored and updated all steno unit tests
- Fixed test isolation issues with syslog mocking
- Created isolated test helper (spec/isolated_specs/steno/spec_helper.rb)

Documentation:
- Added NOTICE file from original steno repository
- Added LICENSE file (Apache 2.0)
- Created comprehensive README.md with integration history
- Documented Rails/Delegate RuboCop change

Related Changes:
- Removed unused ByteQuantity class (replaced by ByteConverter)
- Updated cloud_controller version files

This integration enables better debugging, faster iteration, and eliminates
external dependency management for a critical logging component.

Author: johha

.github/workflows/gem_freshness_report.yml

@@ -22,7 +22,7 @@ jobs:
           cat gem_freshness_report.md >> "$GITHUB_STEP_SUMMARY"
 
       - name: Upload report artifact
-        uses: actions/upload-artifact@v7
+        uses: actions/upload-artifact@v6
         with:
           path: gem_freshness_report.md
           retention-days: 140

Gemfile

@@ -22,6 +22,7 @@ gem 'newrelic_rpm'
 gem 'nokogiri', '>=1.10.5'
 gem 'oj'
 gem 'openssl', '>= 3.2'
+gem 'palm_civet'
 gem 'prometheus-client'
 gem 'public_suffix'
 gem 'puma'
@@ -33,7 +34,7 @@ gem 'sequel_pg', require: 'sequel'
 gem 'sinatra', '~> 4.2'
 gem 'sinatra-contrib'
 gem 'statsd-ruby', '~> 1.5.0'
-gem 'steno'
+gem 'syslog'
 gem 'talentbox-delayed_job_sequel', '~> 4.4.0'
 gem 'uri', '~> 1.1'
 gem 'vmstat', '~> 2.3'
@@ -78,7 +79,7 @@ group :test do
   gem 'rspec-its'
   gem 'rspec-rails', '~> 8.0.3'
   gem 'rspec-wait'
-  gem 'rubocop', '~> 1.85.0'
+  gem 'rubocop', '~> 1.84.2'
   gem 'rubocop-capybara'
   gem 'rubocop-factory_bot'
   gem 'rubocop-rails', '~> 2.34'

Gemfile.lock

@@ -231,15 +231,15 @@ GEM
       google-apis-core (>= 0.11.0, < 2.a)
     google-cloud-env (1.6.0)
       faraday (>= 0.17.3, < 3.0)
-    google-protobuf (4.34.0)
+    google-protobuf (4.33.5)
       bigdecimal
-      rake (~> 13.3)
-    google-protobuf (4.34.0-x86_64-darwin)
+      rake (>= 13)
+    google-protobuf (4.33.5-x86_64-darwin)
       bigdecimal
-      rake (~> 13.3)
-    google-protobuf (4.34.0-x86_64-linux-gnu)
+      rake (>= 13)
+    google-protobuf (4.33.5-x86_64-linux-gnu)
       bigdecimal
-      rake (~> 13.3)
+      rake (>= 13)
     googleapis-common-protos (1.9.0)
       google-protobuf (~> 4.26)
       googleapis-common-protos-types (~> 1.21)
@@ -301,18 +301,15 @@ GEM
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
     machinist (1.0.6)
-    mcp (0.7.1)
-      json-schema (>= 4.1)
     membrane (1.1.0)
     method_source (1.1.0)
     mime-types (3.7.0)
       logger
       mime-types-data (~> 3.2025, >= 3.2025.0507)
-    mime-types-data (3.2026.0224)
+    mime-types-data (3.2026.0203)
     mini_mime (1.1.5)
     mini_portile2 (2.8.9)
-    minitest (6.0.2)
-      drb (~> 2.0)
+    minitest (6.0.1)
       prism (~> 1.5)
     mock_redis (0.53.0)
       redis (~> 5)
@@ -356,6 +353,7 @@ GEM
     openssl (4.0.1)
     os (1.1.4)
     ostruct (0.6.3)
+    palm_civet (1.1.0)
     parallel (1.27.0)
     parallel_tests (5.6.0)
       parallel
@@ -401,8 +399,8 @@ GEM
       activesupport (>= 5.0.0)
       minitest
       nokogiri (>= 1.6)
-    rails-html-sanitizer (1.7.0)
-      loofah (~> 2.25)
+    rails-html-sanitizer (1.6.2)
+      loofah (~> 2.21)
       nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
     railties (8.1.2)
       actionpack (= 8.1.2)
@@ -481,11 +479,10 @@ GEM
       activesupport (>= 3.0.0)
       mustache (~> 1.0, >= 0.99.4)
       rspec (~> 3.0)
-    rubocop (1.85.0)
+    rubocop (1.84.2)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
-      mcp (~> 0.6)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
@@ -581,10 +578,8 @@ GEM
     spring-commands-rspec (1.0.4)
       spring (>= 0.9.1)
     statsd-ruby (1.5.0)
-    steno (1.3.5)
-      fluent-logger
-      yajl-ruby (~> 1.0)
     stringio (3.2.0)
+    syslog (0.1.2)
     talentbox-delayed_job_sequel (4.4.0)
       delayed_job (~> 4.1)
       sequel (>= 5.0, < 6.0)
@@ -612,7 +607,6 @@ GEM
     webrick (1.9.2)
     xml-simple (1.1.9)
       rexml
-    yajl-ruby (1.4.3)
     yard (0.9.38)
     yard-activesupport-concern (0.0.1)
       yard (>= 0.8)
@@ -667,6 +661,7 @@ DEPENDENCIES
   nokogiri (>= 1.10.5)
   oj
   openssl (>= 3.2)
+  palm_civet
   parallel_tests
   pg
   prometheus-client
@@ -685,7 +680,7 @@ DEPENDENCIES
   rspec-rails (~> 8.0.3)
   rspec-wait
   rspec_api_documentation (>= 6.1.0)
-  rubocop (~> 1.85.0)
+  rubocop (~> 1.84.2)
   rubocop-capybara
   rubocop-factory_bot
   rubocop-rails (~> 2.34)
@@ -702,7 +697,7 @@ DEPENDENCIES
   spring
   spring-commands-rspec
   statsd-ruby (~> 1.5.0)
-  steno
+  syslog
   talentbox-delayed_job_sequel (~> 4.4.0)
   timecop
   uri (~> 1.1)

Rakefile

@@ -9,7 +9,7 @@ require File.expand_path('config/boot', __dir__)
 
 require 'yaml'
 require 'sequel'
-require 'steno'
+require 'steno/steno'
 require 'cloud_controller'
 require_relative 'lib/tasks/rake_config'
 

app/models/runtime/process_model.rb

@@ -385,7 +385,7 @@ def started_command
     def run_action_user
       return user if user.present?
 
-      app&.docker? ? docker_run_action_user : AppModel::DEFAULT_CONTAINER_USER
+      docker? ? docker_run_action_user : AppModel::DEFAULT_CONTAINER_USER
     end
 
     def specified_or_detected_command

config/version

@@ -1 +1 @@
-3.215.0
+3.214.0

config/version_v2

@@ -1 +1 @@
-2.280.0
+2.279.0

docs/v2/info/get_info.html

@@ -103,7 +103,7 @@ <h4>Body</h4>
   "token_endpoint": "http://localhost:8080/uaa",
   "min_cli_version": null,
   "min_recommended_cli_version": null,
-  "api_version": "2.280.0",
+  "api_version": "2.279.0",
   "app_ssh_endpoint": "ssh.system.domain.example.com:2222",
   "app_ssh_host_key_fingerprint": "47:0d:d1:c8:c3:3d:0a:36:d1:49:2f:f2:90:27:31:d0",
   "app_ssh_oauth_client": null,

docs/v3/Gemfile.lock

@@ -108,10 +108,11 @@ GEM
     middleman-syntax (3.6.1)
       middleman-core (>= 3.2)
       rouge (~> 3.2)
-    mini_racer (0.20.0)
+    mini_racer (0.19.2)
       libv8-node (~> 24.12.0.1)
     minitest (6.0.1)
       prism (~> 1.5)
+    mutex_m (0.3.0)
     nokogiri (1.19.1-arm64-darwin)
       racc (~> 1.4)
     nokogiri (1.19.1-x86_64-darwin)