Skip to content

Commit 991d44b

Browse files
committed
Rename add_mtls_options to add_route_policy_options and refactor structure
Adopt philippthun's suggested pattern: build a fresh hash and merge at the end instead of duplicating info['options']. Also rename the method and variable from mtls_ prefix to route_policy_ to align with current terminology.
1 parent 238cc0e commit 991d44b

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

lib/cloud_controller/diego/protocol/routing_info.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,19 @@ def build_http_route_info(route_mapping)
5050
info['protocol'] = route_mapping.protocol
5151
info['options'] = r.options if r.options
5252

53-
add_mtls_options(info, r) if r.domain.enforce_route_policies
53+
add_route_policy_options(info, r) if r.domain.enforce_route_policies
5454

5555
info
5656
end
5757

58-
def add_mtls_options(info, route)
59-
# Inject mTLS policy options for enforce_route_policies domains.
58+
def add_route_policy_options(info, route)
59+
# Inject route policy options for enforce_route_policies domains.
6060
# These are GoRouter-internal keys and are filtered from the /v3/routes API.
61-
mtls_options = info['options']&.dup || {}
62-
mtls_options['route_policy_scope'] = route.domain.route_policies_scope if route.domain.route_policies_scope
61+
route_policy_options = {}
62+
route_policy_options['route_policy_scope'] = route.domain.route_policies_scope if route.domain.route_policies_scope
6363
sources = route.route_policies.map(&:source)
64-
mtls_options['route_policy_sources'] = sources.join(',') unless sources.empty?
65-
info['options'] = mtls_options
64+
route_policy_options['route_policy_sources'] = sources.join(',') unless sources.empty?
65+
info['options'] = (info['options'] || {}).merge(route_policy_options)
6666
end
6767

6868
def tcp_info(process_eager)

0 commit comments

Comments
 (0)