report deserialization errors in more detail (#3675)

Report when serialization errors occur in more detail to help debug/fix rare bug if it occurs again.

Author: Benjamintf1

errors/v2.yml

@@ -1353,3 +1353,8 @@
   name: KorifiError
   http_code: 500
   message: "%s"
+
+420001:
+  name: DeserializationError
+  http_code: 500
+  message: "%s"

lib/cloud_controller/serializer.rb

@@ -7,7 +7,12 @@ def serializes_via_json(accessor_method_name)
         string = send("#{accessor_method_name}_without_serialization")
         return if string.blank?
 
-        MultiJson.load string
+        begin
+          MultiJson.load string
+        rescue MultiJson::ParseError
+          error = "Failed to deserialize #{guid} for object type #{self.class}. Trying to deserialize #{string}. You may have to delete and recreate the object"
+          raise CloudController::Errors::ApiError.new_from_details('DeserializationError', error)
+        end
       end
       alias_method "#{accessor_method_name}_without_serialization", accessor_method_name
       alias_method accessor_method_name, "#{accessor_method_name}_with_serialization"