fix: rubocop errors are fixed

serdarozerr · serdarozerr · commit bb30c9894c45 · 2026-03-17T10:25:03.000+01:00
diff --git a/app/models/runtime/app_model.rb b/app/models/runtime/app_model.rb
@@ -99,7 +99,6 @@ def validate
       validates_format APP_NAME_REGEX, :name
       validate_environment_variables
       validate_droplet_is_staged
-
     end
 
     def lifecycle_type
diff --git a/app/models/services/service_plan.rb b/app/models/services/service_plan.rb
@@ -84,7 +84,6 @@ def around_save
       raise validation_failed_error
     end
 
-
     def validate
       validates_presence :name,                message: 'is required'
       validates_presence :description,         message: 'is required'
diff --git a/spec/support/shared_examples/models/domain_validation.rb b/spec/support/shared_examples/models/domain_validation.rb
@@ -13,9 +13,9 @@ module VCAP::CloudController
 
     context "when there's another domain with the same name" do
       it 'fails to validate' do
-        expect {
+        expect do
           described_class.make(name: subject.name)
-        }.to raise_error(Sequel::ValidationFailed, /already reserved by another domain|unique/)
+        end.to raise_error(Sequel::ValidationFailed, /already reserved by another domain|unique/)
       end
     end
 
diff --git a/spec/unit/actions/app_create_spec.rb b/spec/unit/actions/app_create_spec.rb
@@ -200,7 +200,6 @@ module VCAP::CloudController
         end
       end
 
-
       describe 'stack state validation' do
         let(:test_stack) { Stack.make(name: 'test-stack-for-validation') }
         let(:lifecycle_request) { { type: 'buildpack', data: { buildpacks: [buildpack_identifier], stack: test_stack.name } } }
diff --git a/spec/unit/actions/organization_create_spec.rb b/spec/unit/actions/organization_create_spec.rb
@@ -121,7 +121,6 @@ module VCAP::CloudController
               org_create.create(message)
             end.not_to raise_error
 
-
             # Second request, should fail with correct error
             expect do
               org_create.create(message)
diff --git a/spec/unit/actions/service_broker_create_spec.rb b/spec/unit/actions/service_broker_create_spec.rb
@@ -140,7 +140,6 @@ module CloudController
             action.create(message)
           end.not_to raise_error
 
-
           # Second request, should fail with correct error
           expect do
             action.create(message)
diff --git a/spec/unit/actions/space_create_spec.rb b/spec/unit/actions/space_create_spec.rb
@@ -90,7 +90,6 @@ module VCAP::CloudController
               SpaceCreate.new(user_audit_info:).create(org, message)
             end.not_to raise_error
 
-
             # Second request, should fail with correct error
             expect do
               SpaceCreate.new(user_audit_info:).create(org, message)
diff --git a/spec/unit/actions/space_quotas_create_spec.rb b/spec/unit/actions/space_quotas_create_spec.rb
@@ -210,7 +210,6 @@ module VCAP::CloudController
             space_quotas_create.create(message, organization: org)
           end.not_to raise_error
 
-
           # Second request, should fail with correct error
           expect do
             space_quotas_create.create(message, organization: org)
diff --git a/spec/unit/actions/stack_create_spec.rb b/spec/unit/actions/stack_create_spec.rb
@@ -130,7 +130,6 @@ module VCAP::CloudController
             stack_create.create(message)
           end.not_to raise_error
 
-
           # Second request, should fail with correct error
           expect do
             stack_create.create(message)
diff --git a/spec/unit/actions/user_create_spec.rb b/spec/unit/actions/user_create_spec.rb
@@ -44,7 +44,6 @@ module VCAP::CloudController
             subject.create(message:)
           end.not_to raise_error
 
-
           # Second request, should fail with correct error
           expect do
             subject.create(message:)
diff --git a/spec/unit/isolation_segment_create_spec.rb b/spec/unit/isolation_segment_create_spec.rb
@@ -53,7 +53,6 @@ module VCAP::CloudController
             IsolationSegmentCreate.create(message)
           end.not_to raise_error
 
-
           # Second request, should fail with correct error
           expect do
             IsolationSegmentCreate.create(message)
diff --git a/spec/unit/models/runtime/feature_flag_spec.rb b/spec/unit/models/runtime/feature_flag_spec.rb
@@ -9,9 +9,9 @@ module VCAP::CloudController
     describe 'uniqueness' do
       it 'enforces uniqueness of name' do
         existing_flag = FeatureFlag.make
-        expect {
+        expect do
           FeatureFlag.create(name: existing_flag.name, enabled: true)
-        }.to raise_error(Sequel::ValidationFailed, /unique/)
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
 
diff --git a/spec/unit/models/runtime/organization_auditor_spec.rb b/spec/unit/models/runtime/organization_auditor_spec.rb
@@ -5,12 +5,12 @@ module VCAP::CloudController
     let(:organization) { Organization.make }
     let(:user) { User.make }
 
-    describe "uniquiness" do
-      it "prevend dublicate organization_id and user_id combination" do
+    describe 'uniquiness' do
+      it 'prevend dublicate organization_id and user_id combination' do
         OrganizationAuditor.create(organization_id: organization.id, user_id: user.id)
-        expect {
+        expect do
           OrganizationAuditor.create(organization_id: organization.id, user_id: user.id)
-        }.to raise_error(Sequel::ValidationFailed, /unique/)
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
 
diff --git a/spec/unit/models/runtime/organization_billing_manager_spec.rb b/spec/unit/models/runtime/organization_billing_manager_spec.rb
@@ -5,12 +5,12 @@ module VCAP::CloudController
     let(:organization) { Organization.make }
     let(:user) { User.make }
 
-    describe "uniquiness" do
-      it "prevend dublicate organization_id and user_id combination" do
+    describe 'uniquiness' do
+      it 'prevend dublicate organization_id and user_id combination' do
         OrganizationBillingManager.create(organization_id: organization.id, user_id: user.id)
-        expect {
+        expect do
           OrganizationBillingManager.create(organization_id: organization.id, user_id: user.id)
-        }.to raise_error(Sequel::ValidationFailed, /unique/)
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
 
diff --git a/spec/unit/models/runtime/organization_manager_spec.rb b/spec/unit/models/runtime/organization_manager_spec.rb
@@ -5,12 +5,12 @@ module VCAP::CloudController
     let(:organization) { Organization.make }
     let(:user) { User.make }
 
-    describe "uniquiness" do
-      it "prevend dublicate organization_id and user_id combination" do
+    describe 'uniquiness' do
+      it 'prevend dublicate organization_id and user_id combination' do
         OrganizationManager.create(organization_id: organization.id, user_id: user.id)
-        expect {
+        expect do
           OrganizationManager.create(organization_id: organization.id, user_id: user.id)
-        }.to raise_error(Sequel::ValidationFailed, /unique/)
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
 
diff --git a/spec/unit/models/runtime/organization_user_spec.rb b/spec/unit/models/runtime/organization_user_spec.rb
@@ -5,12 +5,12 @@ module VCAP::CloudController
     let(:organization) { Organization.make }
     let(:user) { User.make }
 
-    describe "uniquiness" do
-      it "prevend dublicate organization_id and user_id combination" do
+    describe 'uniquiness' do
+      it 'prevend dublicate organization_id and user_id combination' do
         OrganizationUser.create(organization_id: organization.id, user_id: user.id)
-        expect {
+        expect do
           OrganizationUser.create(organization_id: organization.id, user_id: user.id)
-        }.to raise_error(Sequel::ValidationFailed, /unique/)
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
 
diff --git a/spec/unit/models/runtime/quota_definition_spec.rb b/spec/unit/models/runtime/quota_definition_spec.rb
@@ -17,9 +17,9 @@ module VCAP::CloudController
     describe 'uniqueness' do
       it 'enforces uniqueness of name' do
         existing = QuotaDefinition.make
-        expect {
+        expect do
           QuotaDefinition.create(name: existing.name, non_basic_services_allowed: true, total_services: 0, total_routes: 0, memory_limit: 0)
-        }.to raise_error(Sequel::ValidationFailed, /unique/)
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
 
diff --git a/spec/unit/models/runtime/space_auditor_spec.rb b/spec/unit/models/runtime/space_auditor_spec.rb
@@ -5,12 +5,12 @@ module VCAP::CloudController
     let(:space) { Space.make }
     let(:user) { User.make }
 
-    describe "uniquiness" do
-      it "prevend dublicate space_id and user_id combination" do
+    describe 'uniquiness' do
+      it 'prevend dublicate space_id and user_id combination' do
         SpaceAuditor.create(space_id: space.id, user_id: user.id)
-        expect{
+        expect do
           SpaceAuditor.create(space_id: space.id, user_id: user.id)
-        }.to raise_error(Sequel::ValidationFailed, /unique/) 
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
 
diff --git a/spec/unit/models/runtime/space_developer_spec.rb b/spec/unit/models/runtime/space_developer_spec.rb
@@ -5,14 +5,15 @@ module VCAP::CloudController
     let(:space) { Space.make }
     let(:user) { User.make }
 
-    describe "uniquiness" do
-      it "prevend dublicate space_id and user_id combination" do
+    describe 'uniquiness' do
+      it 'prevend dublicate space_id and user_id combination' do
         SpaceDeveloper.create(space_id: space.id, user_id: user.id)
-        expect{
+        expect do
           SpaceDeveloper.create(space_id: space.id, user_id: user.id)
-        }.to raise_error(Sequel::ValidationFailed, /unique/) 
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
+
     describe 'Validations' do
       it { is_expected.to validate_presence :space_id }
       it { is_expected.to validate_presence :user_id }
diff --git a/spec/unit/models/runtime/space_manager_spec.rb b/spec/unit/models/runtime/space_manager_spec.rb
@@ -5,14 +5,15 @@ module VCAP::CloudController
     let(:space) { Space.make }
     let(:user) { User.make }
 
-    describe "uniquiness" do
-      it "prevend dublicate space_id and user_id combination" do
+    describe 'uniquiness' do
+      it 'prevend dublicate space_id and user_id combination' do
         SpaceManager.create(space_id: space.id, user_id: user.id)
-        expect{
+        expect do
           SpaceManager.create(space_id: space.id, user_id: user.id)
-        }.to raise_error(Sequel::ValidationFailed, /unique/) 
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
+
     describe 'Validations' do
       it { is_expected.to validate_presence :space_id }
       it { is_expected.to validate_presence :user_id }
diff --git a/spec/unit/models/runtime/space_supporter_spec.rb b/spec/unit/models/runtime/space_supporter_spec.rb
@@ -6,14 +6,15 @@ module VCAP::CloudController
     let(:space) { Space.make }
     let(:user) { User.make }
 
-    describe "uniquiness" do
-      it "prevend dublicate space_id and user_id combination" do
+    describe 'uniquiness' do
+      it 'prevend dublicate space_id and user_id combination' do
         SpaceSupporter.create(space_id: space.id, user_id: user.id)
-        expect{
+        expect do
           SpaceSupporter.create(space_id: space.id, user_id: user.id)
-        }.to raise_error(Sequel::ValidationFailed, /unique/) 
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
+
     describe 'Validations' do
       it { is_expected.to validate_presence :space_id }
       it { is_expected.to validate_presence :user_id }
diff --git a/spec/unit/models/services/service_dashboard_client_spec.rb b/spec/unit/models/services/service_dashboard_client_spec.rb
@@ -15,9 +15,9 @@ module VCAP::CloudController
     describe 'uniqueness' do
       it 'enforces uniqueness of uaa_id' do
         existing = ServiceDashboardClient.make(service_broker:)
-        expect {
+        expect do
           ServiceDashboardClient.create(uaa_id: existing.uaa_id, service_broker: other_broker)
-        }.to raise_error(Sequel::ValidationFailed, /unique/)
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
 
diff --git a/spec/unit/models/services/service_key_spec.rb b/spec/unit/models/services/service_key_spec.rb
@@ -22,9 +22,9 @@ module VCAP::CloudController
     describe 'uniqueness' do
       it 'enforces uniqueness of name and service_instance_id' do
         existing = ServiceKey.make
-        expect {
+        expect do
           ServiceKey.make(name: existing.name, service_instance: existing.service_instance)
-        }.to raise_error(Sequel::ValidationFailed, /unique/)
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
 
diff --git a/spec/unit/models/services/service_plan_spec.rb b/spec/unit/models/services/service_plan_spec.rb
@@ -15,9 +15,9 @@ module VCAP::CloudController
     describe 'uniqueness' do
       it 'enforces uniqueness of name within a service' do
         existing = ServicePlan.make
-        expect {
+        expect do
           ServicePlan.make(name: existing.name, service: existing.service)
-        }.to raise_error(Sequel::ValidationFailed, /already has a plan named/)
+        end.to raise_error(Sequel::ValidationFailed, /already has a plan named/)
       end
     end
 
diff --git a/spec/unit/models/services/service_plan_visibility_spec.rb b/spec/unit/models/services/service_plan_visibility_spec.rb
@@ -12,9 +12,9 @@ module VCAP::CloudController
     describe 'uniqueness' do
       it 'enforces uniqueness of organization and service plan combination' do
         existing = ServicePlanVisibility.make
-        expect {
+        expect do
           ServicePlanVisibility.create(service_plan: existing.service_plan, organization: existing.organization)
-        }.to raise_error(Sequel::ValidationFailed, /unique/)
+        end.to raise_error(Sequel::ValidationFailed, /unique/)
       end
     end
 
