Fix rubocop issues

Author: hoffmaen

app/actions/route_create.rb

@@ -78,7 +78,7 @@ def validation_error!(error, host, path, port, space, domain)
 
       error!("Reserved route ports quota exceeded for organization '#{space.organization.name}'.") if error.errors.on(:organization)&.include?(:total_reserved_route_ports_exceeded)
 
-      error!("Hash header must be present when loadbalancing is set to hash") if error.errors.on(:route)&.include?(:hash_header_missing)
+      error!('Hash header must be present when loadbalancing is set to hash') if error.errors.on(:route)&.include?(:hash_header_missing)
 
       validation_error_routing_api!(error)
       validation_error_host!(error, host, domain)

app/actions/route_update.rb

@@ -4,7 +4,6 @@ class Error < StandardError
     end
 
     def update(route:, message:)
-
       Route.db.transaction do
         route.options = route.options.symbolize_keys.merge(message.options) if message.requested?(:options)
         route.save
@@ -25,9 +24,7 @@ def update(route:, message:)
 
     def validation_error!(error)
       # Handle hash_header validation error for hash loadbalancing
-      if error.errors.on(:route)&.include?(:hash_header_missing)
-        raise Error.new('Hash header must be present when loadbalancing is set to hash')
-      end
+      raise Error.new('Hash header must be present when loadbalancing is set to hash') if error.errors.on(:route)&.include?(:hash_header_missing)
 
       # Fallback for any other validation errors
       raise Error.new(error.message)

app/messages/manifest_routes_update_message.rb

@@ -61,7 +61,7 @@ def route_options_are_valid
         r[:options].each_key do |key|
           RouteOptionsMessage.valid_route_options.exclude?(key) &&
             errors.add(:base,
-              message: "Route '#{r[:route]}' contains invalid route option '#{key}'. \
+                       message: "Route '#{r[:route]}' contains invalid route option '#{key}'. \
 Valid keys: '#{RouteOptionsMessage.valid_route_options.join(', ')}'")
         end
       end
@@ -76,13 +76,13 @@ def loadbalancings_are_valid
         loadbalancing = r[:options][:loadbalancing]
         unless loadbalancing.is_a?(String)
           errors.add(:base,
-            message: "Invalid value for 'loadbalancing' for Route '#{r[:route]}'; \
+                     message: "Invalid value for 'loadbalancing' for Route '#{r[:route]}'; \
 Valid values are: '#{RouteOptionsMessage.valid_loadbalancing_algorithms.join(', ')}'")
           next
         end
         RouteOptionsMessage.valid_loadbalancing_algorithms.exclude?(loadbalancing) &&
           errors.add(:base,
-            message: "Cannot use loadbalancing value '#{loadbalancing}' for Route '#{r[:route]}'; \
+                     message: "Cannot use loadbalancing value '#{loadbalancing}' for Route '#{r[:route]}'; \
 Valid values are: '#{RouteOptionsMessage.valid_loadbalancing_algorithms.join(', ')}'")
       end
     end
@@ -106,12 +106,9 @@ def hash_options_are_valid
         hash_balance = options[:hash_balance]
 
         # Validate hash_header length if present
-        if hash_header.present?
-          # Check length (at most 128 characters)
-          if hash_header.to_s.length > 128
-            errors.add(:base, message: "Route '#{r[:route]}': Hash header must be at most 128 characters")
-            next
-          end
+        if hash_header.present? && (hash_header.to_s.length > 128)
+          errors.add(:base, message: "Route '#{r[:route]}': Hash header must be at most 128 characters")
+          next
         end
 
         # Validate hash_balance is numeric if present
@@ -125,7 +122,7 @@ def hash_options_are_valid
           begin
             balance_float = Float(hash_balance)
             # Must be either 0 or >= 1.1 and <= 10.0
-            unless balance_float == 0 || (balance_float >= 1.1 && balance_float <= 10)
+            unless balance_float == 0 || balance_float.between?(1.1, 10)
               errors.add(:base, message: "Route '#{r[:route]}': Hash balance must be either 0 or between to 1.1 and 10.0")
             end
           rescue ArgumentError, TypeError

app/messages/route_options_message.rb

@@ -50,12 +50,9 @@ def hash_options_are_valid
       # Feature flag is enabled - validate hash-specific options
 
       # Validate hash_header length if present
-      if hash_header.present?
-        # Check length (at most 128 characters)
-        if hash_header.to_s.length > 128
-          errors.add(:hash_header, 'must be at most 128 characters')
-          return
-        end
+      if hash_header.present? && (hash_header.to_s.length > 128)
+        errors.add(:hash_header, 'must be at most 128 characters')
+        return
       end
 
       # Validate hash_balance is numeric if present
@@ -69,9 +66,7 @@ def hash_options_are_valid
         begin
           balance_float = Float(hash_balance)
           # Must be either 0 or >= 1.1 and <= 10.0
-          unless balance_float == 0 || (balance_float >= 1.1 && balance_float <= 10)
-            errors.add(:hash_balance, 'must be either 0 or between 1.1 and 10.0')
-          end
+          errors.add(:hash_balance, 'must be either 0 or between 1.1 and 10.0') unless balance_float == 0 || balance_float.between?(1.1, 10)
         rescue ArgumentError, TypeError
           errors.add(:hash_balance, 'must be a numeric value')
         end

app/models/runtime/route.rb

@@ -71,18 +71,12 @@ def as_summary_json
     end
 
     def options_with_serialization=(opts)
-      logger = Steno.logger('cc.model.route')
-      caller_info = caller[0..5].join("\n  ")
-      logger.error("CRITICAL: options_with_serialization= setter called", opts: opts.inspect, caller: caller_info, location: "#{__FILE__}:#{__LINE__}")
-
       cleaned_opts = remove_hash_options_for_non_hash_loadbalancing(opts)
       rounded_opts = round_hash_balance_to_one_decimal(cleaned_opts)
       normalized_opts = normalize_hash_balance_to_string(rounded_opts)
       # Remove nil values after all processing
       normalized_opts = normalized_opts.compact if normalized_opts.is_a?(Hash)
       self.options_without_serialization = Oj.dump(normalized_opts)
-
-      logger.error("CRITICAL: options_with_serialization= setter completed", normalized_opts: normalized_opts.inspect, json: self.options_without_serialization.inspect)
     end
 
     alias_method :options_without_serialization=, :options=
@@ -339,9 +333,9 @@ def validate_route_options
 
       hash_header = route_options[:hash_header] || route_options['hash_header']
 
-      if hash_header.blank?
-        errors.add(:route, :hash_header_missing)
-      end
+      return if hash_header.present?
+
+      errors.add(:route, :hash_header_missing)
     end
 
     def round_hash_balance_to_one_decimal(opts)
@@ -365,6 +359,7 @@ def round_hash_balance_to_one_decimal(opts)
 
     def normalize_hash_balance_to_string(opts)
       return opts unless opts.is_a?(Hash)
+
       # We have a flat structure on options, so no deep_symbolize required
       normalized = opts.symbolize_keys
       normalized[:hash_balance] = normalized[:hash_balance].to_s if normalized[:hash_balance].present?