Commit e4b8026
committed
Move steno tests to isolated_specs to prevent mock leakage
The Steno::Sink::Syslog singleton was causing sporadic test failures
when steno tests ran in parallel with other CCNG tests. RSpec doubles
stored in the singleton would leak into other tests, causing
"double leaked into another example" errors.
Instead of adding workarounds to spec_helper.rb, isolate the steno
tests by moving them to spec/isolated_specs/steno/. This follows
the existing pattern for tests that affect global state.
Changes:
- Move spec/unit/lib/steno/ to spec/isolated_specs/steno/
- Update steno spec_helper to call reset! and close Syslog after tests
- Remove global syslog reset hook from main spec_helper.rb
- Remove :skip_syslog_reset tags (no longer needed)
The reset! method on Steno::Sink::Syslog remains as a clean API for
test cleanup within the isolated steno test suite.1 parent c74756f commit e4b8026
16 files changed
Lines changed: 7 additions & 23 deletions
File renamed without changes.
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
10 | 14 | | |
11 | 15 | | |
12 | 16 | | |
File renamed without changes.
File renamed without changes.
File renamed without changes.
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| |||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
0 commit comments