Remove Spork preloader (#4811)

- Spork is old and unsupported
- I wasn't able to get it working with modern ruby
- Spring is the modern implementation of the same concept

Author: Gerg

Gemfile

@@ -95,7 +95,6 @@ group :development do
   gem 'listen'
   gem 'roodi'
   gem 'solargraph'
-  gem 'spork', git: 'https://github.com/sporkrb/spork', ref: '224df49' # '~> 1.0rc'
   gem 'spring'
   gem 'spring-commands-rspec'
 end

Gemfile.lock

@@ -32,13 +32,6 @@ GIT
       azure-core (~> 0.1.13)
       nokogiri (~> 1.6, >= 1.6.8)
 
-GIT
-  remote: https://github.com/sporkrb/spork
-  revision: 224df492657e617a0c93c0319e78f0eefee5b636
-  ref: 224df49
-  specs:
-    spork (1.0.0rc4)
-
 GEM
   remote: https://rubygems.org/
   specs:
@@ -691,7 +684,6 @@ DEPENDENCIES
   sinatra (~> 4.2)
   sinatra-contrib
   solargraph
-  spork!
   spring
   spring-commands-rspec
   statsd-ruby (~> 1.5.0)

scripts/file_watcher.rb

@@ -159,27 +159,3 @@ real        18.628      2.077       13.934      19.062      21.821
 user        0.177       0.032       0.129       0.185       0.233
 sys         0.103       0.014       0.078       0.107       0.126
 ```
-
-#### Spork (Legacy)
-
-Spork is an older implementation of the same "forking" strategy implemented by Spring.
-
-### Running Individual Tests
-
-In one terminal, change to the `Cloud Controller` root directory and run `bundle exec spork`
-
-In a separate terminal, you can run selected unit tests quickly by running them with the `--drb` option, as in:
-
-    bundle exec rspec --drb spec/unit/models/services/service_plan_visibility_spec.rb
-
-You can configure your IDE to take advantage of spork by inserting the `--drb` option. If `spork` isn't running `rspec` will ignore the `--drb` option and run the test the usual slower way.
-
-Press Ctrl-C in the first terminal to stop running `spork`.
-
-### Running Tests Automatically When Files Change
-
-In one terminal, change to the `Cloud Controller` root directory and run `bundle exec scripts/file-watcher.rb`
-
-As files change, they, or their related spec files, will be run automatically.
-
-Press Ctrl-C to stop running `file-watcher.rb`.

spec/README.md

@@ -3,28 +3,5 @@
 require 'mock_redis'
 require 'spec_helper_helper'
 
-begin
-  require 'spork'
-  # uncomment the following line to use spork with the debugger
-  # require 'spork/ext/ruby-debug'
-
-  run_spork = !`ps | grep spork | grep -v grep`.empty?
-rescue LoadError
-  run_spork = false
-end
-
-if run_spork
-  Spork.prefork do
-    # Loading more in this block will cause your tests to run faster. However,
-    # if you change any configuration or code from libraries loaded here, you'll
-    # need to restart spork for it to take effect.
-    SpecHelperHelper.init
-  end
-  Spork.each_run do
-    # This code will be run each time you run your specs.
-    SpecHelperHelper.each_run
-  end
-else
-  SpecHelperHelper.init
-  SpecHelperHelper.each_run
-end
+SpecHelperHelper.init
+SpecHelperHelper.each_run