Skip to content

Fix application rename with CNB lifecycle #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svkrieger merged 2 commits into from
Feb 12, 2025
Merged

Fix application rename with CNB lifecycle #4206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd42392
Fix application rename with CNB lifecycle
pbusko Feb 4, 2025
a72fc8f
Simplified new code
c0d1ngm0nk3y Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cloud_controller/diego/lifecycles/app_cnb_lifecycle.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def create_lifecycle_data_model(app)
end

def valid?
!buildpacks.empty?
message.is_a?(AppUpdateMessage) || !buildpacks.empty?
end

def errors
Expand Down
8 changes: 8 additions & 0 deletions spec/unit/lib/cloud_controller/diego/lifecycles/app_cnb_lifecycle_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,14 @@ module VCAP::CloudController
it 'invalid' do
expect(lifecycle.valid?).to be(false)
end

context 'during an update' do
let(:message) { VCAP::CloudController::AppUpdateMessage.new(request) }

it 'valid' do
expect(lifecycle.valid?).to be(true)
end
end
end

context 'with buildpacks' do
Expand Down