[RFC0030 - 3] Rename 'file-based-service-bindings' to 'service-binding-k8s' and introduce 'file-based-vcap-services' #4235
Merged
svkrieger merged 7 commits intocloudfoundry:mainfrom Mar 11, 2025
Conversation
svkrieger
force-pushed
the
rename-file-based-service-bindings-to-service-binding-k8s
branch
4 times, most recently
from
deaca88 to
75b058b
Compare
svkrieger
force-pushed
the
rename-file-based-service-bindings-to-service-binding-k8s
branch
from
75b058b to
3abe847
Compare
svkrieger
changed the title
5 tasks
13 tasks
svkrieger
changed the title
jochenehret
reviewed
Mar 11, 2025
app/presenters/v3/app_file_based_vcap_services_feature_presenter.rb
Outdated
Show resolved
Hide resolved
svkrieger
changed the title
jochenehret
approved these changes
Mar 11, 2025
svkrieger
deleted the
rename-file-based-service-bindings-to-service-binding-k8s
branch
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Mar 12, 2025
Changes in cloud_controller_ng:
- MariaDB version in CAPI pipeline has yet another error message. Make test more generic.
PR: cloudfoundry/cloud_controller_ng#4255
Author: Sven Krieger <37476281+svkrieger@users.noreply.github.com>
- Try to fix flaky stager test part 2
PR: cloudfoundry/cloud_controller_ng#4261
Author: Sven Krieger <37476281+svkrieger@users.noreply.github.com>
- Fix flaky stager test
PR: cloudfoundry/cloud_controller_ng#4256
Author: Sven Krieger <37476281+svkrieger@users.noreply.github.com>
- Bump postgres version in gh workflows
PR: cloudfoundry/cloud_controller_ng#4254
Author: Johannes Haass <johannes.haass@sap.com>
- [RFC0030 - 3] Rename 'file-based-service-bindings' to 'service-binding-k8s' and introduce 'file-based-vcap-services'
PR: cloudfoundry/cloud_controller_ng#4235
Author: Sven Krieger <37476281+svkrieger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Following the changed requirement in https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0030-add-support-for-file-based-service-binding.md
file-based-service-bindingsgets renamed toservice-binding-k8s.Introducing a new column in the apps table here. We need to remove the old column when the code has been rolled out.
Additionally introducing a second option also mentioned in the RFC
file-based-vcap-services.Both features are mutually exclusive.
An explanation of the use cases your change solves
Links to any other associated PRs
Previous PRs, which introduced
file-based-service-bindingsfeature:This PR is prerequisite for merging the following PR:
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests