Skip to content

Fix flaky reoccurring job test #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philippthun merged 1 commit into from
Apr 10, 2025
Merged

Fix flaky reoccurring job test #4257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions spec/unit/jobs/reoccurring_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,15 @@ def perform
TestConfig.config[:jobs][:priorities] = { 'fake-job': 20 }

pollable_job = Jobs::Enqueuer.new({ queue: Jobs::Queues.generic, priority: 22 }).enqueue_pollable(FakeJob.new)
expect(Delayed::Job.where(guid: PollableJobModel.first.delayed_job_guid).first[:priority]).to eq(42)
first_delayed_job_guid = pollable_job.delayed_job_guid
expect(Delayed::Job.where(guid: first_delayed_job_guid).first[:priority]).to eq(42)

execute_all_jobs(expected_successes: 1, expected_failures: 0, jobs_to_execute: 1)

expect(Delayed::Job.where(guid: PollableJobModel.first.delayed_job_guid).first[:priority]).to eq(42)
expect(PollableJobModel.first.delayed_job_guid).not_to eq(pollable_job.delayed_job_guid)
pollable_job.reload
second_delayed_job_guid = pollable_job.delayed_job_guid
expect(Delayed::Job.where(guid: second_delayed_job_guid).first[:priority]).to eq(42)
expect(first_delayed_job_guid).not_to eq(second_delayed_job_guid)
end

it 'waits for the polling interval' do
Expand Down