Skip to content

Ensure generic enqueuer is reset correctly #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johha merged 1 commit into from
Mar 18, 2025
Merged

Ensure generic enqueuer is reset correctly #4258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/unit/jobs/generic_enqueuer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def perform

before do
# Reset singleton instance to ensure clean tests
Thread.current[:generic_enqueuer] = nil
GenericEnqueuer.reset!
end

describe '.shared' do
Expand Down
2 changes: 2 additions & 0 deletions spec/unit/jobs/reoccurring_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ def perform
it 'keeps the delayed job\'s priority when re-enqueuing' do
TestConfig.config[:jobs][:priorities] = { 'fake-job': 20 }

Jobs::GenericEnqueuer.reset! # Ensure no previous state interferes

pollable_job = Jobs::Enqueuer.new({ queue: Jobs::Queues.generic, priority: 22 }).enqueue_pollable(FakeJob.new)
expect(Delayed::Job.where(guid: PollableJobModel.first.delayed_job_guid).first[:priority]).to eq(42)

Expand Down