Issue 4404: Add support for "icmpv6" protocol to ASGs#4424
Merged
jochenehret merged 6 commits intomainfrom Jul 8, 2025
Merged
Conversation
* "icmpv6" can be used if "enable_ipv6" is configured * "icmp" destinations may only consist of IPv4 addresses * "icmpv6" destinations may only consist of IPv6 addresses
jochenehret
force-pushed
the
icmpv6_asg_validation
branch
2 times, most recently
from
8a52df1 to
b822c6a
Compare
jochenehret
force-pushed
the
icmpv6_asg_validation
branch
from
b822c6a to
7ce40e2
Compare
jochenehret
force-pushed
the
icmpv6_asg_validation
branch
from
7ce40e2 to
fd4265c
Compare
svkrieger
previously approved these changes
Jul 7, 2025
svkrieger
approved these changes
Jul 8, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jul 8, 2025
Changes in cloud_controller_ng:
- Issue 4404: Add support for "icmpv6" protocol to ASGs
PR: cloudfoundry/cloud_controller_ng#4424
Author: Jochen Ehret <jochen.ehret@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for "impv6" validation in ASGs:
"icmpv6" can be used if "enable_ipv6" is configured
"icmp" destinations may only consist of IPv4 addresses
"icmpv6" destinations may only consist of IPv6 addresses
An explanation of the use cases your change solves
Part of the IPv6 support story.
#4404
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rake