Add unique constraint for running security groups#4617
Merged
Conversation
Table `security_group_spaces` does not have unique constraint which can result in duplicated entries. This change adds a migration to replace the existing index with a unique index. Duplicated entries will be cleaned up during the migration by keeping the oldest combination of `security_group_id` and `space_id` (determined by primary key). In addition unique constraint errors will be caught to make parallel inserts idempotent.
Contributor
|
lgtm |
kathap
approved these changes
Oct 24, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Oct 27, 2025
Changes in cloud_controller_ng:
- Add unique constraint for running security groups
PR: cloudfoundry/cloud_controller_ng#4617
Author: Johannes Haass <johannes.haass@sap.com>
sethboyles
pushed a commit
to atanas-attodorov-wq/cloud_controller_ng
that referenced
this pull request
Dec 11, 2025
Table `security_group_spaces` does not have unique constraint which can result in duplicated entries. This change adds a migration to replace the existing index with a unique index. Duplicated entries will be cleaned up during the migration by keeping the oldest combination of `security_group_id` and `space_id` (determined by primary key). In addition unique constraint errors will be caught to make parallel inserts idempotent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table
security_group_spacesdoes not have a unique constraint which can result in duplicated entries. This change adds a migration to replace the existing index with a unique index. Duplicated entries will be cleaned up during the migration by keeping the oldest combination ofsecurity_group_idandspace_id(determined by primary key). In addition unique constraint errors will be caught to make parallel inserts idempotent.This will fix #4602.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests