Cloud Foundry do not parse SB response and do not include custom metadata#4618
Closed
atanas-attodorov-wq wants to merge 1 commit intocloudfoundry:mainfrom
Closed
Cloud Foundry do not parse SB response and do not include custom metadata#4618atanas-attodorov-wq wants to merge 1 commit intocloudfoundry:mainfrom
atanas-attodorov-wq wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
|
|
…ata that comes from SI
atanas-attodorov-wq
force-pushed
the
parse_metadata_from_sb
branch
from
2bc4abb to
a7cefed
Compare
atanas-attodorov-wq
changed the title
Benjamintf1
reviewed
Nov 4, 2025
| end | ||
|
|
||
| # Merge broker labels into CF labels (broker labels take precedence for conflicts) | ||
| cf_labels.merge(broker_labels) |
Member
There was a problem hiding this comment.
I'm not sure merging the broker labels in with the user defined labels is the correct solution here.
While, I think, without passing the broker attributes to the user it remains terribly useful, i think conflating the osabi labels with user labels because they are specified with the same word might be the wrong choice.
Contributor
Author
There was a problem hiding this comment.
I agree . Can you have a look at this discussion?
#4633
In the project i am working ,this will not be needed anymore. I am closing this PR. If someone say it is feasible , i can re-open the PR and contribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tanzu Data service tiles (like Postgres) bundle a specific engine version (e.g., Postgres 16.6), but this version is not visible on the ServiceInstance object in Cloud Foundry. This makes it hard for users to know which version they are consuming.
The Open Service Broker API (OSBI) already has a ServiceInstanceMetadata field to store this type of information, Even if the on-demand-service-broker (ODB) propagate the metadata it is not consumed during parsing in CAPI.
This change makes the service version visible in Cloud Foundry by using the existing OSBI metadata field. This is a three-part process:
Service Adapter: The service-adapter (e.g., the Postgres tile's adapter) will be updated to add the engine version as a key-value pair in the tags section of the BOSH manifest it generates (e.g., postgres_version: "16.6").
On-Demand Service Broker (ODB): The ODB will be modified to read this new version tag from the manifest. The ODB will then take this value and populate the Metadata field in its ProvisionedServiceSpec and UpdateServiceSpec responses to Cloud Foundry.
Cloud Controller will parse that metadata and merge with labels that comes from the Service Broker. The labels which comes from Service Broker will be shown only if the SI is managed.
[Yes ] I have reviewed the contributing guide
[Yes] I have viewed, signed, and submitted the Contributor License Agreement
[ Yes] I have made this pull request to the
mainbranch[Yes ] I have run all the unit tests using
bundle exec rake[ No] I have run CF Acceptance Tests