Conversation
Replace Net::SSH::Buffer with native Ruby implementation for SSH wire format encoding. The new implementation uses standard Ruby pack/unpack directives to encode SSH public key blobs per RFC 4251 and RFC 4253. Changes: - Implement ssh_string() for SSH string encoding (length-prefixed) - Implement ssh_mpint() for SSH multiple precision integer encoding - Add helper methods for readability (uint32_big_endian, zero_byte, etc.) - Update test to parse SSH blob without Net::SSH::Buffer - Remove net-ssh from Gemfile Manually tested all combinations to ensure compatibility: - Old implementation + old test (baseline) - Old implementation + new test - New implementation + old test - New implementation + new test All combinations pass, confirming the new implementation produces identical SSH wire format output.
johha
force-pushed
the
remove-net-ssh-gem
branch
from
989ced5 to
eff191c
Compare
jochenehret
approved these changes
Mar 18, 2026
Contributor
Author
|
Tested |
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Mar 18, 2026
Changes in cloud_controller_ng:
- Remove net-ssh gem dependency from SSHKey
PR: cloudfoundry/cloud_controller_ng#4929
Author: Johannes Haass <johannes.haass@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Net::SSH::Buffer with native Ruby implementation for SSH wire format encoding. The new implementation uses standard Ruby pack/unpack directives to encode SSH public key blobs per RFC 4251 and RFC 4253.
Changes:
Manually tested all combinations to ensure compatibility:
All combinations pass, confirming the new implementation produces identical SSH wire format output
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests