Fix default_order_by_id for association loading#5089
Merged
johha merged 1 commit intocloudfoundry:mainfrom May 7, 2026
Merged
Conversation
philippthun
force-pushed
the
fix-default-order-by-id-association-loading
branch
5 times, most recently
from
edd3da4 to
d142e3c
Compare
philippthun
force-pushed
the
fix-default-order-by-id-association-loading
branch
from
d142e3c to
a664767
Compare
|
|
philippthun
force-pushed
the
fix-default-order-by-id-association-loading
branch
2 times, most recently
from
e9fc957 to
3bcb699
Compare
johha
force-pushed
the
fix-default-order-by-id-association-loading
branch
from
3bcb699 to
ae9f315
Compare
johha
approved these changes
May 7, 2026
johha
force-pushed
the
fix-default-order-by-id-association-loading
branch
from
ae9f315 to
e3f4ca5
Compare
Add placeholder_literalizer_loader hook so the extension applies ORDER BY id to Sequel association queries that use the optimized loader path. Add tests to buildpack and CNB lifecycle data model specs verifying the association is ordered by id via the extension.
johha
force-pushed
the
fix-default-order-by-id-association-loading
branch
from
e3f4ca5 to
7af3e9e
Compare
|
/easycla |
Contributor
|
@lukaszgryglicki thanks for fixing/reverting 👍 |
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 7, 2026
Changes in cloud_controller_ng:
- Fix default_order_by_id for association loading
PR: cloudfoundry/cloud_controller_ng#5089
Author: Philipp Thun <philipp.thun@sap.com>
Author: johha <johannes.haass@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
placeholder_literalizer_loaderhook so the extension appliesORDER BY idto Sequel association queries that use the optimized loader path.Add tests to buildpack and CNB lifecycle data model specs verifying the association is ordered by id via the extension.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests