Skip to content

Add missing _spec suffix to service operations cleanup test#5191

Merged
philippthun merged 1 commit into
cloudfoundry:mainfrom
sap-contributions:fix-service-operations-spec-filename
Jul 14, 2026
Merged

Add missing _spec suffix to service operations cleanup test#5191
philippthun merged 1 commit into
cloudfoundry:mainfrom
sap-contributions:fix-service-operations-spec-filename

Conversation

@philippthun

Copy link
Copy Markdown
Member

The file was added in #5011 without the _spec suffix, so rspec's default pattern (spec/**/*_spec.rb) skipped its 18 examples.

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

The file was added in cloudfoundry#5011 without the _spec suffix, so rspec's
default pattern (spec/**/*_spec.rb) skipped its 18 examples.
@philippthun philippthun force-pushed the fix-service-operations-spec-filename branch from 35badfb to 237478e Compare June 29, 2026 13:17
@svkrieger svkrieger self-requested a review July 14, 2026 12:48
@philippthun philippthun merged commit f3190c8 into cloudfoundry:main Jul 14, 2026
11 checks passed
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Jul 14, 2026
Changes in cloud_controller_ng:

- Add missing _spec suffix to service operations cleanup test
    PR: cloudfoundry/cloud_controller_ng#5191
    Author: Philipp Thun <philipp.thun@sap.com>

- Performance fixes for permission queries
    PR: cloudfoundry/cloud_controller_ng#5172
    Author: Philipp Thun <philipp.thun@sap.com>

Dependency updates in cloud_controller_ng:

- build(deps): bump json from 2.20.0 to 2.21.1
    PR: cloudfoundry/cloud_controller_ng#5281
    Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants