Propagate options-only route changes immediately in route-emitter#1155
Draft
Samze wants to merge 1 commit into
Draft
Propagate options-only route changes immediately in route-emitter#1155Samze wants to merge 1 commit into
Samze wants to merge 1 commit into
Conversation
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
Factor in Route options and perform a route register without unregistering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1154
Factor in Route options and perform a route register without unregistering.
Summary
When only a route's
optionschanged (e.g.loadbalancingstrategy), route-emitter does not emit the update. It only happens on the next periodic heartbeat. This happened becausediffRoutesdoes not factor in Route Options changes.diffRoutesnow also emits route registration for when options have changed.Backward Compatibility
Breaking Change? No