Fix cacheddownloader diego ssh dialcontext#1167
Merged
Merged
Conversation
…al with DialContext Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
Replace Dial with DialContext in cacheddownloader and diego-ssh SSH tunnel tests. Also remove unreachable setup==nil branch in transformer.go — safe because NewTimedStep wraps nil and returns nil from Run. ai-assisted=yes [TNZ-92428]
…field Replace Admin.AccessLogPath (removed in newer envoy API) with a structured AccessLog entry. Vendor envoy access_loggers/file/v3 package. Update proxy_config_handler tests accordingly.
…Shares The inline //lint:ignore SA1019 on LimitInShares fires a "directive didn't match" error on Windows staticcheck (SA1019 doesn't trigger for that symbol on Windows). Add a package-level staticcheck.conf disabling SA1019 for the containerstore package instead. LimitInShares is still set in production code and asserted in tests — the suppression only covers the deprecation warning.
…FreeSpaceEx Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace deprecated MatchSubjectAltNames with MatchTypedSubjectAltNames. Diego container identity certs use DNSNames (container GUID + internal routes), so hardcode SanType=DNS. Update tests to match.
ameowlia
force-pushed
the
fix-cacheddownloader-diego-ssh-dialcontext
branch
from
17ee7ae to
8b1e01c
Compare
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix unit tests