Add some more unit tests

Author: jorbaum

src/pkg/egress/syslog/filtering_drain_writer.go

@@ -79,11 +79,9 @@ func (w *FilteringDrainWriter) Write(env *loggregator_v2.Envelope) error {
 		}
 	}
 	if env.GetLog() != nil {
-		// Default to sending logs if no source_type tag is present
 		value, ok := env.GetTags()["source_type"]
 		if !ok {
-			// TODO add unit test for case where source_type tag is missing
-			// source_type tag is missing, default to sending logs
+			// Default to sending logs if no source_type tag is present
 			value = ""
 		}
 		if sendsLogs(w.binding.DrainData, w.binding.LogFilter, value) {
@@ -117,7 +115,6 @@ func shouldIncludeLog(logFilter *LogTypeSet, sourceTypeTag string) bool {
 	logType, known := logTypePrefixes[prefix]
 	if !known {
 		// Unknown log type, default to not filtering
-		// TODO unit test
 		return true
 	}
 
@@ -126,7 +123,6 @@ func shouldIncludeLog(logFilter *LogTypeSet, sourceTypeTag string) bool {
 }
 
 func sendsLogs(drainData DrainData, logFilter *LogTypeSet, sourceTypeTag string) bool {
-	// TODO ALL appears to be special?
 	if drainData != LOGS && drainData != LOGS_AND_METRICS && drainData != LOGS_NO_EVENTS {
 		return false
 	}

src/pkg/egress/syslog/filtering_drain_writer_test.go

@@ -53,6 +53,60 @@ var _ = Describe("Filtering Drain Writer", func() {
 		_, err := syslog.NewFilteringDrainWriter(binding, &fakeWriter{})
 		Expect(err).To(HaveOccurred())
 	})
+
+	It("sends logs when source_type tag is missing", func() {
+		binding := syslog.Binding{
+			DrainData: syslog.LOGS,
+			LogFilter: nil,
+		}
+		fakeWriter := &fakeWriter{}
+		drainWriter, err := syslog.NewFilteringDrainWriter(binding, fakeWriter)
+		Expect(err).NotTo(HaveOccurred())
+
+		envelope := &loggregator_v2.Envelope{
+			Message: &loggregator_v2.Envelope_Log{
+				Log: &loggregator_v2.Log{
+					Payload: []byte("test log"),
+				},
+			},
+			Tags: map[string]string{
+				// source_type tag is intentionally missing
+			},
+		}
+
+		err = drainWriter.Write(envelope)
+
+		Expect(err).NotTo(HaveOccurred())
+		Expect(fakeWriter.received).To(Equal(1))
+	})
+
+	It("sends logs with unknown source_type prefix when filter is set", func() {
+		appFilter := syslog.LogTypeSet{syslog.APP: struct{}{}}
+		binding := syslog.Binding{
+			DrainData: syslog.LOGS,
+			LogFilter: &appFilter,
+		}
+		fakeWriter := &fakeWriter{}
+		drainWriter, err := syslog.NewFilteringDrainWriter(binding, fakeWriter)
+		Expect(err).NotTo(HaveOccurred())
+
+		envelope := &loggregator_v2.Envelope{
+			Message: &loggregator_v2.Envelope_Log{
+				Log: &loggregator_v2.Log{
+					Payload: []byte("test log"),
+				},
+			},
+			Tags: map[string]string{
+				"source_type": "UNKNOWN/some/path",
+			},
+		}
+
+		err = drainWriter.Write(envelope)
+
+		// Should send the log because unknown types default to being included
+		Expect(err).NotTo(HaveOccurred())
+		Expect(fakeWriter.received).To(Equal(1))
+	})
 })
 
 type fakeWriter struct {