fix linter findings

Author: chombium

src/rlp-gateway/app/config.go

@@ -22,7 +22,7 @@ type LogAccessAuthorization struct {
 type LogAdminAuthorization struct {
 	Addr         string `env:"LOG_ADMIN_ADDR,          required, report"`
 	ClientID     string `env:"LOG_ADMIN_CLIENT_ID,     required"`
-	ClientSecret string `env:"LOG_ADMIN_CLIENT_SECRET, required"`
+	ClientSecret string `env:"LOG_ADMIN_CLIENT_SECRET, required"` //nolint:gosec
 	CAPath       string `env:"LOG_ADMIN_CA_PATH,       required, report"`
 }
 

src/rlp-gateway/app/gateway_test.go

@@ -469,7 +469,7 @@ func (tc *testClient) open(url string) (*http.Response, error) {
 	}
 	req.Header.Set("Authorization", "my-token")
 
-	resp, err := tc.client.Do(req)
+	resp, err := tc.client.Do(req) //nolint:gosec
 	if err != nil {
 		panic(err)
 	}

src/rlp-gateway/internal/auth/capi_client.go

@@ -129,7 +129,7 @@ func (c *CAPIClient) AvailableSourceIDs(token string) []string {
 	}(resp)
 
 	if resp.StatusCode != http.StatusOK {
-		log.Printf("CAPI request failed (/v3/apps): %d", resp.StatusCode)
+		log.Printf("CAPI request failed (/v3/apps): %d", resp.StatusCode) //nolint:gosec
 		return nil
 	}
 
@@ -169,7 +169,7 @@ func (c *CAPIClient) AvailableSourceIDs(token string) []string {
 	}(resp)
 
 	if resp.StatusCode != http.StatusOK {
-		log.Printf("CAPI request failed (/v3/service_instances): %d", resp.StatusCode)
+		log.Printf("CAPI request failed (/v3/service_instances): %d", resp.StatusCode) //nolint:gosec
 		return nil
 	}
 

src/testservers/router.go

@@ -41,7 +41,7 @@ func StartRouter(conf app.Config) (cleanup func(), rp RouterPorts) {
 	Expect(routerPath).ToNot(BeEmpty())
 
 	By("starting router")
-	routerCommand := exec.Command(routerPath)
+	routerCommand := exec.Command(routerPath) //nolint:gosec
 	routerCommand.Env = envstruct.ToEnv(&conf)
 
 	routerSession, err := gexec.Start(

src/testservers/setup.go

@@ -40,7 +40,7 @@ func waitForPortBinding(prefix string, buf *gbytes.Buffer) int {
 		if len(result) == 2 {
 			port, err := strconv.Atoi(string(result[1]))
 			if err != nil {
-				log.Panicf("unable to parse port number, port: %#v", result[1])
+				log.Panicf("unable to parse port number, port: %#v", result[1]) //nolint:gosec
 			}
 			return port
 		}

src/testservers/traffic_controller.go

@@ -57,7 +57,7 @@ func StartTrafficController(conf tcConf.Config) (cleanup func(), tp TrafficContr
 	Expect(tcPath).ToNot(BeEmpty())
 
 	By("starting trafficcontroller")
-	tcCommand := exec.Command(tcPath)
+	tcCommand := exec.Command(tcPath) //nolint:gosec
 	tcCommand.Env = envstruct.ToEnv(&conf)
 	tcSession, err := gexec.Start(
 		tcCommand,

src/trafficcontroller/internal/auth/log_access_authorizer.go

@@ -35,7 +35,7 @@ func NewLogAccessAuthorizer(c *http.Client, disableAccessControl bool, apiHost s
 		}
 
 		req.Header.Set("Authorization", authToken)
-		res, err := c.Do(req)
+		res, err := c.Do(req) //nolint:gosec
 		if err != nil {
 			log.Printf("Could not get app information: [%s]", err)
 			return http.StatusInternalServerError, err
@@ -44,7 +44,7 @@ func NewLogAccessAuthorizer(c *http.Client, disableAccessControl bool, apiHost s
 
 		err = nil
 		if res.StatusCode != 200 {
-			log.Printf("Non 200 response from CC API: %d for %q", res.StatusCode, target)
+			log.Printf("Non 200 response from CC API: %d for %q", res.StatusCode, target) //nolint:gosec
 			err = errors.New(http.StatusText(res.StatusCode))
 		}
 

src/trafficcontroller/internal/auth/uaa_client.go

@@ -38,7 +38,7 @@ func (c *uaaClient) GetAuthData(token string) (*AuthData, error) {
 	req.SetBasicAuth(c.id, c.secret)
 	req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
 
-	response, err := c.httpClient.Do(req)
+	response, err := c.httpClient.Do(req) //nolint:gosec
 	if err != nil {
 		return nil, err
 	}

src/trafficcontroller/internal/proxy/admin_access_middleware.go

@@ -23,7 +23,7 @@ func (m *AdminAccessMiddleware) Wrap(h http.Handler) http.Handler {
 		if !authorized {
 			w.Header().Set("WWW-Authenticate", "Basic")
 			w.WriteHeader(http.StatusUnauthorized)
-			fmt.Fprintf(w, "You are not authorized. %s", err.Error())
+			fmt.Fprintf(w, "You are not authorized. %s", err.Error()) //nolint:gosec
 			return
 		}
 

src/trafficcontroller/internal/proxy/websocket_server.go

@@ -92,7 +92,7 @@ func (s *WebSocketServer) ServeWS(
 					eventBody,
 				)
 
-				log.Printf("Doppler Proxy: Slow Consumer from %s using %s", r.RemoteAddr, r.URL)
+				log.Printf("Doppler Proxy: Slow Consumer from %s using %s", r.RemoteAddr, r.URL) //nolint:gosec
 				return
 			}
 		}