Reuse installed ginkgo and use cleaner binary check

Author: jorbaum

scripts/subtests/lint

@@ -5,10 +5,7 @@ set -o pipefail
 
 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
 
-set +e
-golangci_lint_executable=$(which golangci-lint)
-set -e
-if [ -z "${golangci_lint_executable}" ] || [ ! -x "${golangci_lint_executable}" ]; then
+if ! command -v golangci-lint &> /dev/null; then
   go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest
 fi
 

scripts/subtests/unit-test

@@ -11,6 +11,8 @@ if [ "${CI:-false}" = 'false' ]; then
 fi
 
 pushd "${SCRIPT_DIR}/../../src" > /dev/null
-    go run github.com/onsi/ginkgo/v2/ginkgo $flags
-popd > /dev/null
-
+    if ! command -v ginkgo &> /dev/null; then
+      go install github.com/onsi/ginkgo/v2/ginkgo@latest
+    fi
+    ginkgo $flags 
+popd > /dev/null