Merged
Conversation
Noteworthy changes in golangci-lint v2:
* New config format (migrated with `migrate` command)
* Default timeout is now 0 instead of 1 minute.
Also fixes issues reported by golangci-lint v2:
* Same error string capitalization. Details:
* Also changed two asserts in a test
* Also removed "Error:" prefix
* Prefer embedded field
* Lift `break` into loop condition
* Prefer tagged switch in some test files
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
chombium
requested changes
Sep 30, 2025
| sourceID: sourceID, | ||
| } | ||
| m.Tagged.tags = make(map[string]*loggregator_v2.Value) | ||
| m.tags = make(map[string]*loggregator_v2.Value) |
Contributor
There was a problem hiding this comment.
please revert this. The Tagged struct is used to unify the format of the tags among counters and gauges
Contributor
There was a problem hiding this comment.
I've taken another look at this, This doesn't make any difference in the usage of the fields. As long as we keep and use the Tagged struct everywhere, there will be no problems.
| sourceID: sourceID, | ||
| } | ||
| m.Tagged.tags = make(map[string]*loggregator_v2.Value) | ||
| m.tags = make(map[string]*loggregator_v2.Value) |
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move to golangci-lint v2.
Issues were:
breakinto loop conditionNoteworthy changes in golangci-lint v2:
migratecommand)Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch