Adding user info related information regarding deployment process actions#1869
Adding user info related information regarding deployment process actions#1869karrgov wants to merge 3 commits into
Conversation
…ions LMCROSSITXSADEPLOY-3329
| public static final String UNBINDING_SERVICE_INSTANCE_FROM_APP_FINISHED = "Unbinding service instance \"{0}\" from application \"{1}\" finished"; | ||
| public static final String POLLING_SERVICE_OPERATIONS = "Polling service operations..."; | ||
| public static final String AUTO_ABORTING_PROCESS_0 = "Auto-aborting process \"{0}\"..."; | ||
| public static final String AUTO_ABORTING_PROCESS_0 = "Auto-aborting process with processId: \"{0}\", action: \"{1}\", actor: system ..."; |
There was a problem hiding this comment.
what is the point of actor here?
| ProcessAction abortAction = processActionRegistry.getAction(Action.ABORT); | ||
| String processId = operation.getProcessId(); | ||
| LOGGER.debug(CleanUpJob.LOG_MARKER, format(Messages.ABORTING_OPERATION_0, processId)); | ||
| LOGGER.info(MessageFormat.format(Messages.AUTO_ABORTING_PROCESS_0, processId, Action.ABORT.toString())); |
There was a problem hiding this comment.
Why do you pass the process type when you only pass abort. I think you can hard code it
There was a problem hiding this comment.
Just wanted to make it more consistent with the other logs I have added - will hard code it, thanks.
LMCROSSITXSADEPLOY-3329
| ProcessAction abortAction = processActionRegistry.getAction(Action.ABORT); | ||
| String processId = operation.getProcessId(); | ||
| LOGGER.debug(CleanUpJob.LOG_MARKER, format(Messages.ABORTING_OPERATION_0, processId)); | ||
| LOGGER.info(MessageFormat.format(Messages.AUTO_ABORTING_PROCESS_0, processId)); |
There was a problem hiding this comment.
Why another logging was added instead editing first one?
There was a problem hiding this comment.
Because the first one was a debug one and I did not want to change what we have had until now - my idea was to add a second info log
| public static final String OBJECT_STORE_WITH_PROVIDER_0_CREATED = "Object store with provider: {0} created"; | ||
| public static final String JOB_WITH_ID_WAS_NOT_UPDATED_WITHIN_SECONDS = "Job with ID: {} was not updated within: {} seconds"; | ||
| public static final String CLEARING_OLD_ENTRY = "Clearing old entry with id: {0}"; | ||
| public static final String STARTED_NEW_DEPLOYMENT_PROCESS = "Started new MTA deployment process with process instance id: \"{0}\" and origin of: \"{1}\", by user with user GUID: \"{2}\"."; |
There was a problem hiding this comment.
I think this message can be shortened - Started operation \"{operation_id}\" by user \"{user_guid}\" and origin \"{origin_string}\"
What do you think about this?
There was a problem hiding this comment.
Fixed, I think It might be better shorter as well now that I have seen it
|
| public static final String CLEARING_OLD_ENTRY = "Clearing old entry with id: {0}"; | ||
| public static final String STARTED_NEW_DEPLOYMENT_PROCESS = "Started new MTA deployment process with process instance id: \"{0}\" and origin of: \"{1}\", by user with user GUID: \"{2}\"."; | ||
| public static final String STARTED_OPERATION_0_BY_USER_1_AND_ORIGIN_OF_2 = "Started operation \"{0}\" by user \"{1}\" and origin of \"{2}\"."; | ||
| ; |
| .build(); | ||
| } | ||
|
|
||
| protected void logStartOperation(String processInstanceId, UserInfo authenticatedUser) { |
There was a problem hiding this comment.
Can we have only one logStartOperation method? Also why this method use protected access modifies instead of private?
3 participants
Adding user info related information regarding deployment process actions