Remove redundant version values from default config#1171
Merged
Conversation
arjun024
force-pushed
the
remove-redd-val-options-json
branch
from
c7b29bd to
e681e9c
Compare
Remove PHP_ vars in defaults/options.json. This information is redundant and can be deduced from the buildpack's manifest. Immediate reason: Dependency-update PRs generated by CI ends up in conflict and they do not automerge as each PR tries to update its version value in defaults/options.json CI PR to stop updating options.json: cloudfoundry/buildpacks-ci#432
arjun024
force-pushed
the
remove-redd-val-options-json
branch
from
e681e9c to
6d238b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
PHP_vars indefaults/options.json. This information is redundant and can be deduced from the buildpack's manifest.Immediate reason: Dependency-update PRs generated by CI ends up in conflict and they do not automerge as each PR tries to update its version value in defaults/options.json
CI PR to stop updating options.json: cloudfoundry/buildpacks-ci#432