feat: Update the gitignore file to ignore changed go.mod and go.sum files. Use the vendors instead of the root dependencies

Author: ZPascal

.gitignore

@@ -1,4 +1,5 @@
 go.mod
+go.sum
 tags
 cmd/routing-api/routing-api
 /routing-api

cmd/routing-api/routing_api_suite_test.go

@@ -70,10 +70,7 @@ var _ = SynchronizedBeforeSuite(
 		Expect(err).NotTo(HaveOccurred())
 
 		locketPath, err := gexec.Build("code.cloudfoundry.org/locket/cmd/locket", "-race")
-		if err != nil {
-			// If building locket fails due to missing dependencies, skip the test
-			Skip(fmt.Sprintf("Skipping test suite: locket dependency issue - %v", err))
-		}
+		Expect(err).NotTo(HaveOccurred())
 
 		return []byte(strings.Join([]string{routingAPIBin, locketPath}, ","))
 	},
@@ -82,9 +79,6 @@ var _ = SynchronizedBeforeSuite(
 
 		path := string(binPaths)
 		parts := strings.Split(path, ",")
-		if len(parts) < 2 || parts[1] == "" {
-			Skip("Skipping test suite: locket binary not available")
-		}
 		routingAPIBinPath = parts[0]
 		locketBinPath = parts[1]
 

db/db_sql.go

@@ -128,7 +128,6 @@ func NewSqlDB(cfg *config.SqlDB) (*SqlDB, error) {
 		return nil, err
 	}
 
-	// Use the connection pool and setup it
 	sqlDB, err := db.DB()
 	if err != nil {
 		return nil, err

db/db_sql_test.go

@@ -2085,13 +2085,10 @@ var _ = Describe("SqlDB", func() {
 				It("eventually resolves the issue", func() {
 					timeout := 10.0
 
-					// Verify successful pruning starts working
 					Eventually(logger, timeout).Should(gbytes.Say(`"prune.successfully-finished-pruning-tcp-routes","log_level":1,"data":{"rowsAffected":1}`))
 
-					// Verify errors occur
 					Eventually(logger, timeout).Should(gbytes.Say(`failed-to-prune-tcp-routes","log_level":2,"data":{"error":"temp-error"}`))
 
-					// Verify recovery with more rows
 					Eventually(logger, timeout).Should(gbytes.Say(`"prune.successfully-finished-pruning-tcp-routes","log_level":1,"data":{"rowsAffected":111}`))
 				})
 			})

db/fakes/fake_client.go

@@ -27,7 +27,6 @@ func (v *V2UpdateRgMigration) Run(sqlDB *db.SqlDB) error {
 		return err
 	}
 
-	// Check for duplicates
 	nameMap := make(map[string]int)
 	for _, rg := range rgs {
 		nameMap[rg.Name]++
@@ -39,7 +38,6 @@ func (v *V2UpdateRgMigration) Run(sqlDB *db.SqlDB) error {
 		}
 	}
 
-	// Remove old index if it exists
 	dropIndex(sqlDB, "idx_rg_name", "router_groups")
 
 	// Create unique index - MySQL requires length prefix for text columns

migration/V2_update_rg_migration.go

@@ -55,7 +55,6 @@ var _ = Describe("V2UpdateRgMigration", func() {
 			})
 
 			It("does not allow duplicate router group names", func() {
-				// Verify that the unique index was created
 				migrator := sqlDB.Client.Migrator()
 				hasIndex := migrator.HasIndex("router_groups", "idx_rg_name")
 				Expect(hasIndex).To(BeTrue(), "Index idx_rg_name should exist on router_groups table")

migration/V2_update_rg_migration_test.go

@@ -17,7 +17,6 @@ func (v *V4AddRgUniqIdxTCPRoute) Version() int {
 }
 
 func (v *V4AddRgUniqIdxTCPRoute) Run(sqlDB *db.SqlDB) error {
-	// Drop existing index if it exists
 	dropIndex(sqlDB, "idx_tcp_route", "tcp_routes")
 
 	// Create unique index - MySQL requires length prefixes for text columns

migration/V4_add_rg_uniq_idx_tcp_route_migration.go

@@ -78,7 +78,6 @@ var _ = Describe("V5SniHostnameMigration", func() {
 			})
 
 			It("denies adding the same TCP routes with same SNI hostnames", func() {
-				// Verify that the unique index was created
 				migrator := sqlDB.Client.Migrator()
 				hasIndex := migrator.HasIndex("tcp_routes", "idx_tcp_route")
 				Expect(hasIndex).To(BeTrue(), "Index idx_tcp_route should exist on tcp_routes table")

migration/V5_sni_hostname_migration_test.go

@@ -23,7 +23,6 @@ func (v *V6TCPTLSRoutes) Run(sqlDB *db.SqlDB) error {
 		return err
 	}
 
-	// Drop existing index if it exists
 	dropIndex(sqlDB, "idx_tcp_route", "tcp_routes")
 
 	// Create unique index - MySQL requires length prefixes for text columns