-
Notifications
You must be signed in to change notification settings - Fork 112
RFC0055 Identity-Aware Routing #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
d3ab855
Add per-domain mTLS configuration support to GoRouter config
rkoster 012071b
Implement per-domain TLS configuration via GetConfigForClient
rkoster 1032c7d
Make clientcert handler domain-aware
rkoster 3ff36fe
Add BOSH configuration support for mTLS domains
rkoster 8edbccd
Add AllowedSources support for mTLS authorization (Phase 1b partial)
rkoster 72428d2
Copy AllowedSourceAppGUIDs in NewEndpoint constructor
rkoster 5950fc0
Add identity extraction handler for mTLS caller identification
rkoster d8a4d09
Add mTLS authorization handler for app-to-app access control
rkoster c0cd088
Wire identity and authorization handlers into proxy chain
rkoster 4614259
Add AllowedSourceAppGUIDs support to route-registrar
rkoster 76db306
Fix domain names to match RFC specification
rkoster 0fadbd7
Expand AllowedSources to full RFC specification
rkoster 306714e
Add comprehensive integration tests for mTLS app-to-app routing
rkoster 61faa43
Fix mTLS authorization to use RoutePool instead of RouteEndpoint
rkoster 480023b
Support allowed_sources nested in options for CAPI/Diego integration
rkoster baabb50
Fix identity extraction to handle GoRouter XFCC format (raw base64)
rkoster 37b6a12
Rename AllowedSources to MtlsAllowedSources for clarity
rkoster 1095b70
Add configurable XFCC format support (raw/envoy)
rkoster 811869e
Emit RTR access logs for denied mTLS requests
rkoster fd3d17e
Refactor mTLS route options to RFC-0027 compliant flat format
rkoster 899e6aa
Implement RFC domain-scoped mTLS app-to-app routing in GoRouter
rkoster 84e3db2
feat(gorouter): implement RFC-compliant post-selection mTLS authoriza…
rkoster 68b17b2
refactor: rename MtlsAuthError to AuthError for future extensibility
rkoster 687fe93
refactor: extract shared mTLS helper functions to mtls_helpers.go
rkoster d690778
refactor: remove deprecated mtls_authorization handler
rkoster 57e4153
refactor: move helper functions to their respective handlers
rkoster 22d1eb6
refactor: introduce AuthResult and remove mTLS-specific naming
rkoster fd7e98b
refactor: rename test variable mtlsErr to authErr for consistency
rkoster 5849c6e
refactor: rename mtlsAllowedSources parameter to allowedSources in te…
rkoster cdbb486
refactor: align integration test naming with RFC terminology
rkoster d987d3d
refactor: remove unused EndpointPool methods from deprecated pre-sele…
rkoster e72b52d
refactor: remove identity-aware routing fields from route-registrar
rkoster 4df9d74
chore: add devbox files to .gitignore
rkoster 964c6a2
fix: run gofmt on post_selection_pipeline_test.go
rkoster f9cee18
fix: run gofmt on all modified Go files
rkoster f21ae09
fix: resolve go vet and staticcheck issues
rkoster 682bbb6
fix: resolve integration test failures for identity-aware routing
rkoster 28b7e1b
fix: run gofmt on modified files
rkoster b8342cd
chore: trigger CI after rebase on develop
rkoster f2269df
fix: stop router before NATS in integration test cleanup
rkoster 1d4f0f7
chore: trigger CI for port conflict fix
rkoster 59d4260
refactor: rebrand access rules to route policies terminology
rkoster 04a99e4
fix: apply gofmt to test files for CI compliance
rkoster 29085ca
fix: update integration test to use renamed struct fields
rkoster 2306ecb
fix: route policy enforcement on routes without enforcement enabled
rkoster c50bb24
fix: strip port from Host header before mTLS domain matching
rkoster 054ed35
fix: apply gofmt to mtls_route_policies_auth_test.go
rkoster b68ca47
fix(test): correct expectations for routes without enforcement enabled
rkoster f22798d
fix: address PR #535 code review findings
rkoster baea967
fix: resolve PR #535 code review findings
rkoster d9b86fc
fix: address critical security and correctness issues in mTLS routing
rkoster a3f0b45
fix: add missing tests and fix AuthError dead-code path in proxy pipe…
rkoster d6e369b
fix: reject always_forward+xfcc_format combination at deploy time
rkoster 4bdb317
Validate xfcc_format + always_forward conflict at Go config level
rkoster 7f8d9a0
go mod tidy && go mod vendor
rkoster 04afb2b
fix: add missing locket/lock, cactus/go-statsd-client and grpc/transp…
rkoster 141928b
fix: always emit identity fields in access logs with renamed keys
rkoster 38c6ada
fix: downgrade per-request auth denial logs from INFO to DEBUG
rkoster db58685
fix: add cross-references to spec descriptions and ERB template valid…
rkoster a9410b2
fix: address PR #535 review findings for identity handler
rkoster 2f78d4b
fix: split MtlsPreAuth handler to resolve identity extraction regression
rkoster 45e7abd
test: add unit tests for pool-level RoutePolicyScope and RoutePolicies
rkoster 8bc0718
fix: make mTLS domain matching case-insensitive per RFC 1035
rkoster ca770cf
fix: use endpoint-level route policies for per-endpoint authorization
rkoster d762fd8
fix: complete case-insensitive mTLS domain matching per RFC 1035
rkoster cb78473
fix: remove per-request log statements to comply with gorouter loggin…
rkoster 5ee42de
feat: return no-op handlers when no mTLS domains configured
rkoster a2e1cdb
style: gofmt mtls_route_policies_auth_test.go
rkoster eba1576
feat: include route_policy_scope and route_policies in /routes endpoi…
rkoster 6e1128e
fix: move mTLS access log fields to extra_access_log_fields opt-in
rkoster af99f8e
fix: add missing processMtlsDomains error tests and normalize casing …
rkoster 61ec244
test: add handler tests for identity-aware access log fields
rkoster bd4ecb0
refactor: extract post-selection auth into postselection package
rkoster cc16961
fix: add postselection package to gorouter package spec
rkoster 686f78f
test: use specific TLS error strings in integration tests
rkoster e367664
test: remove invalid per-endpoint route policy integration test
rkoster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.