Destroy prior kubernetes list-config effects on re-entry

The kubernetes signal-config services (namespaces, pods, nodes, node-pods,
namespace-pods, analysis-reports, services, helm-releases, monocular-charts)
are providedIn:'root' singletons, but their host tabs call initialize() from
the component constructor on every mount. The name-filter effect() was created
uncaptured, so each navigation stacked a live effect on the root injector,
recomputing the filter predicate N times per keystroke after N visits.

Capture the EffectRef and destroy the prior one at the top of initialize().
Mirrors the existing capture+destroy pattern already used elsewhere (e.g.
CfAppsSignalConfigService.resolverEffect).

Author: nabramovitz

src/frontend/packages/kubernetes/src/helm/list-types/monocular-charts-signal-config.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
+import { EffectRef, Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
 
 import { ListStateStore, SignalListSort, naturalCompare } from '@stratosui/core';
 
@@ -107,6 +107,10 @@ export class MonocularChartsSignalConfigService {
 
   view!: KubeViewPipeline<MonocularChart>;
 
+  // Captured so a re-entry (root singleton, but initialize() runs per mount)
+  // destroys the prior filter effect instead of stacking one per navigation.
+  private filterEffect?: EffectRef;
+
   errors(): Signal<StratosError[]> {
     return this.helmData.errors();
   }
@@ -125,8 +129,9 @@ export class MonocularChartsSignalConfigService {
       this._sortExtractors.asReadonly(),
     );
 
+    this.filterEffect?.destroy();
     runInInjectionContext(this.injector, () => {
-      effect(() => {
+      this.filterEffect = effect(() => {
         const q = this.nameFilter().trim().toLowerCase();
         const repo = this.repositoryFilter();
         const isHubFilter = repo === 'Artifact Hub';

src/frontend/packages/kubernetes/src/kubernetes/list-types/analysis-reports/analysis-reports-signal-config.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
+import { EffectRef, Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
 import { firstValueFrom } from 'rxjs';
 
 import { ListStateStore, SignalListSort } from '@stratosui/core';
@@ -129,6 +129,10 @@ export class AnalysisReportsSignalConfigService {
 
   view!: KubeViewPipeline<AnalysisReport>;
 
+  // Captured so a re-entry (root singleton, but initialize() runs per mount)
+  // destroys the prior filter effect instead of stacking one per navigation.
+  private filterEffect?: EffectRef;
+
   errors(): Signal<StratosError[]> {
     return this.analysisData.errors();
   }
@@ -154,8 +158,9 @@ export class AnalysisReportsSignalConfigService {
       this._sortExtractors.asReadonly(),
     );
 
+    this.filterEffect?.destroy();
     runInInjectionContext(this.injector, () => {
-      effect(() => {
+      this.filterEffect = effect(() => {
         const q = this.nameFilter().trim().toLowerCase();
         this.filter.set((r: AnalysisReport) => {
           if (!q) return true;

src/frontend/packages/kubernetes/src/kubernetes/list-types/kubernetes-namespace-pods/kubernetes-namespace-pods-signal-config.service.ts

@@ -1,4 +1,5 @@
 import {
+  EffectRef,
   Injectable,
   Injector,
   Signal,
@@ -119,6 +120,10 @@ export class KubernetesNamespacePodsSignalConfigService {
 
   view!: KubePodViewPipeline;
 
+  // Captured so a re-entry (root singleton, but initialize() runs per mount)
+  // destroys the prior filter effect instead of stacking one per navigation.
+  private filterEffect?: EffectRef;
+
   errors(): Signal<StratosError[]> {
     return this.podData.errors();
   }
@@ -142,8 +147,9 @@ export class KubernetesNamespacePodsSignalConfigService {
       this._sortExtractors.asReadonly(),
     );
 
+    this.filterEffect?.destroy();
     runInInjectionContext(this.injector, () => {
-      effect(() => {
+      this.filterEffect = effect(() => {
         const q = this.nameFilter().trim().toLowerCase();
         this.filter.set((p: KubePod) => {
           if (!q) return true;

src/frontend/packages/kubernetes/src/kubernetes/list-types/kubernetes-namespaces/kubernetes-namespaces-signal-config.service.spec.ts

@@ -2,7 +2,7 @@ import { provideHttpClient } from '@angular/common/http';
 import { HttpTestingController, provideHttpClientTesting } from '@angular/common/http/testing';
 import { provideZonelessChangeDetection } from '@angular/core';
 import { TestBed } from '@angular/core/testing';
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
 
 import { KubeEndpointDataRegistry } from '../../../services/endpoint-data/kube-endpoint-data.registry';
 import { KubeNamespaceDataService } from '../../../services/domain-data/kube-namespace-data.service';
@@ -123,6 +123,26 @@ describe('KubernetesNamespacesSignalConfigService', () => {
     expect(svc.pageIndex()).toBe(0);
   });
 
+  it('initialize does not stack a filter effect on re-entry', () => {
+    // Regression: this service is a root singleton, but the host tab calls
+    // initialize() from its constructor on every mount. The filter effect
+    // was created uncaptured, so each navigation left a live effect on the
+    // root injector — N visits meant the filter predicate was recomputed N
+    // times per keystroke. The fix captures the EffectRef and destroys the
+    // prior one on re-entry.
+    svc.initialize(KUBE_GUID);
+    svc.initialize(KUBE_GUID);
+    TestBed.tick();
+
+    const setSpy = vi.spyOn(svc.filter, 'set');
+    svc.nameFilter.set('abc');
+    TestBed.tick();
+
+    // One live effect → one filter recompute. Without the fix the two
+    // stacked effects would each fire, yielding 2.
+    expect(setSpy).toHaveBeenCalledTimes(1);
+  });
+
   it('refresh re-fetches namespaces only', async () => {
     svc.initialize(KUBE_GUID);
     const loading = svc.loadAll();

src/frontend/packages/kubernetes/src/kubernetes/list-types/kubernetes-namespaces/kubernetes-namespaces-signal-config.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
+import { EffectRef, Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
 
 import { ListStateStore, SignalListSort } from '@stratosui/core';
 
@@ -60,6 +60,11 @@ export class KubernetesNamespacesSignalConfigService {
 
   view!: KubeViewPipeline<KubeNamespace>;
 
+  // Captured so a re-entry (this is a root singleton, but components call
+  // initialize() on every mount) destroys the prior filter effect instead
+  // of stacking one live effect per navigation on the root injector.
+  private filterEffect?: EffectRef;
+
   // Tristate visibility — when the kube version / namespace fetch is
   // listed in the endpoint service's `unavailable`, we surface that to
   // the consumer so the page can render "Not Available" rather than a
@@ -87,8 +92,9 @@ export class KubernetesNamespacesSignalConfigService {
       this._sortExtractors.asReadonly(),
     );
 
+    this.filterEffect?.destroy();
     runInInjectionContext(this.injector, () => {
-      effect(() => {
+      this.filterEffect = effect(() => {
         const q = this.nameFilter().trim().toLowerCase();
         this.filter.set((ns: KubeNamespace) => {
           if (!q) return true;

src/frontend/packages/kubernetes/src/kubernetes/list-types/kubernetes-node-pods/kubernetes-node-pods-signal-config.service.ts

@@ -1,4 +1,5 @@
 import {
+  EffectRef,
   Injectable,
   Injector,
   Signal,
@@ -119,6 +120,10 @@ export class KubernetesNodePodsSignalConfigService {
 
   view!: KubePodViewPipeline;
 
+  // Captured so a re-entry (root singleton, but initialize() runs per mount)
+  // destroys the prior filter effect instead of stacking one per navigation.
+  private filterEffect?: EffectRef;
+
   errors(): Signal<StratosError[]> {
     return this.podData.errors();
   }
@@ -142,8 +147,9 @@ export class KubernetesNodePodsSignalConfigService {
       this._sortExtractors.asReadonly(),
     );
 
+    this.filterEffect?.destroy();
     runInInjectionContext(this.injector, () => {
-      effect(() => {
+      this.filterEffect = effect(() => {
         const q = this.nameFilter().trim().toLowerCase();
         this.filter.set((p: KubePod) => {
           if (!q) return true;

src/frontend/packages/kubernetes/src/kubernetes/list-types/kubernetes-nodes/kubernetes-nodes-signal-config.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
+import { EffectRef, Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
 
 import { ListStateStore, SignalListSort } from '@stratosui/core';
 
@@ -54,6 +54,10 @@ export class KubernetesNodesSignalConfigService {
 
   view!: KubeViewPipeline<KubeNode>;
 
+  // Captured so a re-entry (root singleton, but initialize() runs per mount)
+  // destroys the prior filter effect instead of stacking one per navigation.
+  private filterEffect?: EffectRef;
+
   errors(): Signal<StratosError[]> {
     const svc = this.kubeGuid ? this.registry.getService(this.kubeGuid) : null;
     return computed(() => [...(svc?.errors() ?? []), ...this.nodeData.errors()()]);
@@ -77,8 +81,9 @@ export class KubernetesNodesSignalConfigService {
       this._sortExtractors.asReadonly(),
     );
 
+    this.filterEffect?.destroy();
     runInInjectionContext(this.injector, () => {
-      effect(() => {
+      this.filterEffect = effect(() => {
         const q = this.nameFilter().trim().toLowerCase();
         this.filter.set((n: KubeNode) => {
           if (!q) return true;

src/frontend/packages/kubernetes/src/kubernetes/list-types/kubernetes-pods/kubernetes-pods-signal-config.service.ts

@@ -1,4 +1,5 @@
 import {
+  EffectRef,
   Injectable,
   Injector,
   Signal,
@@ -130,6 +131,10 @@ export class KubernetesPodsSignalConfigService {
 
   view!: KubePodViewPipeline;
 
+  // Captured so a re-entry (root singleton, but initialize() runs per mount)
+  // destroys the prior filter effect instead of stacking one per navigation.
+  private filterEffect?: EffectRef;
+
   errors(): Signal<StratosError[]> {
     return this.podData.errors();
   }
@@ -152,8 +157,9 @@ export class KubernetesPodsSignalConfigService {
       this._sortExtractors.asReadonly(),
     );
 
+    this.filterEffect?.destroy();
     runInInjectionContext(this.injector, () => {
-      effect(() => {
+      this.filterEffect = effect(() => {
         const q = this.nameFilter().trim().toLowerCase();
         this.filter.set((p: KubePod) => {
           if (!q) return true;

src/frontend/packages/kubernetes/src/kubernetes/list-types/kubernetes-services/kubernetes-services-signal-config.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
+import { EffectRef, Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
 
 import { ListStateStore, SignalListSort } from '@stratosui/core';
 
@@ -51,6 +51,10 @@ export class KubernetesServicesSignalConfigService {
 
   view!: KubeViewPipeline<KubeService>;
 
+  // Captured so a re-entry (root singleton, but initialize() runs per mount)
+  // destroys the prior filter effect instead of stacking one per navigation.
+  private filterEffect?: EffectRef;
+
   errors(): Signal<StratosError[]> {
     const svc = this.kubeGuid ? this.registry.getService(this.kubeGuid) : null;
     return computed(() => [...(svc?.errors() ?? []), ...this.serviceData.errors()()]);
@@ -74,8 +78,9 @@ export class KubernetesServicesSignalConfigService {
       this._sortExtractors.asReadonly(),
     );
 
+    this.filterEffect?.destroy();
     runInInjectionContext(this.injector, () => {
-      effect(() => {
+      this.filterEffect = effect(() => {
         const q = this.nameFilter().trim().toLowerCase();
         this.filter.set((s: KubeService) => {
           if (!q) return true;

src/frontend/packages/kubernetes/src/kubernetes/workloads/list-types/helm-releases-signal-config.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
+import { EffectRef, Injectable, Injector, Signal, WritableSignal, computed, effect, inject, runInInjectionContext, signal } from '@angular/core';
 
 import { ListStateStore, SignalListSort } from '@stratosui/core';
 
@@ -118,6 +118,10 @@ export class HelmReleasesSignalConfigService {
 
   view!: KubeViewPipeline<HelmRelease>;
 
+  // Captured so a re-entry (root singleton, but initialize() runs per mount)
+  // destroys the prior filter effect instead of stacking one per navigation.
+  private filterEffect?: EffectRef;
+
   errors(): Signal<StratosError[]> {
     return this.helmData.errors();
   }
@@ -136,8 +140,9 @@ export class HelmReleasesSignalConfigService {
       this._sortExtractors.asReadonly(),
     );
 
+    this.filterEffect?.destroy();
     runInInjectionContext(this.injector, () => {
-      effect(() => {
+      this.filterEffect = effect(() => {
         const q = this.nameFilter().trim().toLowerCase();
         const kubeId = this.kubeIdFilter();
         const ns = this.namespaceFilter();