Make specs + test-infra type-check under strict; retire dead test-runner types (#5446)

The app strict flip also made specs strict, but nothing in the gate
type-checks specs (vitest transpiles via esbuild; ng build excludes them),
and vestigial karma->vitest `types` entries (jasmine/jasminewd2/karma,
vitest/globals) caused a tsc config-error short-circuit that MASKED the
whole surface. Unmask it and make specs genuinely strict-clean.

Config / tooling:
- Drop dead jasmine/jasminewd2/karma from the base `types`; repair the
  broken (unused) entity-catalog-test-helpers (this.vi -> vi, drop jasmine.Spy).
- Add `@test-framework/*` path mapping (core->cloud-foundry->store fallback)
  and `@stratosui/core/*` / `@stratosui/store/*` deep-subpath mappings so
  tsc/IDE resolve test imports the way the vitest aliases already do.
- tsconfig.app.json: exclude `*.spec.ts` + config files (matches ng build's
  scope; app config should not type-check tests).
- tsconfig.spec.json: drop the non-resolving `vitest/globals` (globals:false
  -> specs import explicitly); exclude config files + non-test demo packages
  (example-extensions, desktop-extensions).

Specs (52 files): fix ~230 strict-null / implicit-any / missing-vitest-import
findings. Real guards and faithful mock types; `!` only for fixture values
the test itself seeds, each with a // strict: comment. Test intent and
assertions preserved.

Verified: tsc -p app = 0, tsc -p spec = 0, ng build clean, full vitest
2604 passed / 0 failed, eslint 0 errors.

Author: nabramovitz

src/frontend/packages/cf-autoscaler/src/core/autoscaler-helpers/autoscaler-transform-metric.spec.ts

@@ -1,4 +1,6 @@
 import { describe, it, expect } from 'vitest';
+import { PaginationResponse } from '../../../../cloud-foundry/src/store/types/cf-api.types';
+import { AppAutoscalerMetricData } from '../../store/app-autoscaler.types';
 import {
   isEqual,
 } from './autoscaler-util';
@@ -29,12 +31,11 @@ describe('Autoscaler Transform Metric Helper', () => {
   });
   it('buildMetricData', () => {
     const metricName = 'throughput';
-    const data = {
+    const data: PaginationResponse<AppAutoscalerMetricData> = {
       total_results: 12,
       total_pages: 1,
-      page: 1,
-      prev_url: null as string | null,
-      next_url: null as string | null,
+      prev_url: '',
+      next_url: '',
       resources: [
         {
           app_id: '2bd98ff4-99f4-422a-a037-172298277c8b',

src/frontend/packages/cloud-foundry/src/features/applications/application-delete/app-routes-picker.component.spec.ts

@@ -25,6 +25,7 @@ const routeA: StRoute = {
   path: '',
   domainGuid: 'd-1',
   spaceGuid: 's-1',
+  cnsiGuid: 'cnsi-1',
   createdAt: '',
   updatedAt: '',
 };
@@ -36,6 +37,7 @@ const routeB: StRoute = {
   path: '/api',
   domainGuid: 'd-1',
   spaceGuid: 's-1',
+  cnsiGuid: 'cnsi-1',
   createdAt: '',
   updatedAt: '',
 };

src/frontend/packages/cloud-foundry/src/features/applications/application/application-tabs-base/application-tabs-base.component.spec.ts

@@ -69,8 +69,7 @@ describe('ApplicationTabsBaseComponent', () => {
         RawPath: '',
         ForceQuery: false,
         RawQuery: '',
-        Fragment: '',
-        RawFragment: ''
+        Fragment: ''
       },
       authorization_endpoint: '',
       token_endpoint: '',
@@ -86,7 +85,8 @@ describe('ApplicationTabsBaseComponent', () => {
       sso_allowed: false,
       sub_type: '',
       metadata: {},
-      logged_in_as_admin: false
+      metricsAvailable: false,
+      creator: { name: 'test-user', admin: false, system: false }
     };
 
     const endpointsMap: WritableSignal<Map<string, EndpointModel>> = signal(

src/frontend/packages/cloud-foundry/src/features/applications/applications.routes.spec.ts

@@ -1,3 +1,4 @@
+import { describe, it, expect } from 'vitest';
 import { Route } from '@angular/router';
 
 import { APPLICATIONS_ROUTES } from './applications.routes';

src/frontend/packages/cloud-foundry/src/features/applications/deploy-application/deploy-application-step2-1/deploy-application-step2-1.component.spec.ts

@@ -49,15 +49,18 @@ describe('DeployApplicationStep21Component', () => {
 
     it('onNext pins the selected commit SHA when not deploying latest HEAD', () => {
       (component as unknown as { selectedCommitSubject: { next(c: GitCommit): void } }).selectedCommitSubject.next(commit);
-      component.onNext();
+      // strict: onNext's impl is a zero-arg arrow that ignores the stepper's
+      // (index, step) contract args; call it via its real runtime shape.
+      (component.onNext as () => unknown)();
       expect(deployData.setDeployCommit).toHaveBeenCalledWith('abc123def456');
     });
 
     it('onNext sends an empty commit (deploy latest HEAD) when that option is chosen', () => {
       // Even with a commit still selected underneath, latest-HEAD wins and unpins.
       (component as unknown as { selectedCommitSubject: { next(c: GitCommit): void } }).selectedCommitSubject.next(commit);
       (component as unknown as { useLatestHeadSubject: { next(v: boolean): void } }).useLatestHeadSubject.next(true);
-      component.onNext();
+      // strict: see above — onNext ignores the (index, step) contract args.
+      (component.onNext as () => unknown)();
       expect(deployData.setDeployCommit).toHaveBeenCalledWith('');
     });
   });

src/frontend/packages/cloud-foundry/src/features/applications/deploy-application/deploy-application-step2/deploy-application-step2.component.spec.ts

@@ -215,7 +215,9 @@ describe('DeployApplicationStep2Component', () => {
       // setupForGit's other upstream collaborators just enough to reach the
       // suggestedRepos$ assignment where the tap callback is registered.
       const valueChanges = new Subject<Record<string, string | undefined>>();
-      (component as unknown as { sourceSelectionForm: { valueChanges: Subject<unknown> } }).sourceSelectionForm = {
+      (component as unknown as {
+        sourceSelectionForm: { valueChanges: Subject<Record<string, string | undefined>> };
+      }).sourceSelectionForm = {
         valueChanges,
       };
       // updateSuggestedRepositories is called inside switchMap; stub it to

src/frontend/packages/cloud-foundry/src/features/applications/edit-application/edit-application.component.spec.ts

@@ -4,7 +4,7 @@ import { describe, it, expect, beforeEach } from 'vitest';
 
 import { TabNavService } from '@stratosui/core';
 import { STORE_TEST_PROVIDERS } from '@stratosui/store/testing';
-import { ApplicationStateService } from '@stratosui/shared';
+import { ApplicationStateService } from '../../../shared/services/application-state.service';
 import { generateTestApplicationServiceProvider } from '@test-framework/application-service-helper';
 import { ApplicationEnvVarsHelper } from '../application/application-tabs-base/tabs/build-tab/application-env-vars.service';
 import { EditApplicationComponent } from './edit-application.component';

src/frontend/packages/cloud-foundry/src/features/cf/add-space/create-space-step/create-space-step.component.spec.ts

@@ -13,7 +13,8 @@ import {
   EntityCatalogHelpers,
 } from '@stratosui/store';
 import { STORE_TEST_PROVIDERS, testSCFEndpointGuid, populateStoreWithTestEndpoint } from '@stratosui/store/testing';
-import { generateTestCfEndpointServiceProvider, ActiveRouteCfOrgSpace } from "@test-framework/cloud-foundry-endpoint-service.helper";
+import { generateTestCfEndpointServiceProvider } from "@test-framework/cloud-foundry-endpoint-service.helper";
+import { ActiveRouteCfOrgSpace } from "../../cf-page.types";
 import { generateCFEntities } from '@stratosui/cloud-foundry';
 import { CreateSpaceStepComponent } from "./create-space-step.component";
 

src/frontend/packages/cloud-foundry/src/features/cf/users/invite-users/invite-users-create/invite-users-create.component.spec.ts

@@ -111,7 +111,9 @@ describe('InviteUsersCreateComponent', () => {
     } as any);
 
     // Drive the same code path the wizard uses on submit.
-    await firstValueFrom(component.onNext());
+    // strict: onNext's impl ignores the stepper's (index, step) contract
+    // args; call it via its real runtime shape.
+    await firstValueFrom((component.onNext as () => ReturnType<typeof component.onNext>)());
 
     expect(markStale).toHaveBeenCalledWith(testSCFEndpointGuid);
   });

src/frontend/packages/cloud-foundry/src/features/cf/users/manage-users/cf-roles.service.spec.ts

@@ -90,8 +90,9 @@ describe('CfRolesService', () => {
     expect(first.entityRequestInfo.fetching).toBe(true);
     expect(first.entity).toBeNull();
     expect(second.entityRequestInfo.fetching).toBe(false);
-    expect(second.entity.metadata.guid).toBe('org-1');
-    expect(second.entity.entity.name).toBe('My Org');
+    // strict: the loaded emission (fetching=false) always carries a non-null entity
+    expect(second.entity!.metadata.guid).toBe('org-1');
+    expect(second.entity!.entity.name).toBe('My Org');
   });
 
   it('fetchOrgs hits the native list endpoint with per_page paging', () => {
@@ -147,7 +148,8 @@ describe('CfRolesService', () => {
     expect(org.permissions.users).toBe(true);
     expect(org.permissions.auditors).toBe(false);
 
-    const space = org.spaces['space-1'];
+    // strict: this user has a space-1 role under org-1, so spaces is populated
+    const space = org.spaces!['space-1'];
     expect(space.spaceGuid).toBe('space-1');
     expect(space.name).toBe('My Space');
     expect(space.permissions.developers).toBe(true);
@@ -173,8 +175,9 @@ describe('CfRolesService', () => {
     expect(Object.keys(roles)).toEqual(['user-9']);
     const org = roles['user-9']['org-2'];
     expect(org).toBeTruthy();
-    expect(org.spaces['space-2'].permissions.auditors).toBe(true);
-    expect(org.spaces['space-2'].name).toBe('Space Two');
+    // strict: the space-only role auto-creates org-2 with a populated spaces map
+    expect(org.spaces!['space-2'].permissions.auditors).toBe(true);
+    expect(org.spaces!['space-2'].name).toBe('Space Two');
   });
 
   it('populateRoles drains all org pages so names beyond the first page still resolve', async () => {