Fix strict-sweep behavior regressions caught by unit tests (#5446)

The strict sweep changed a few runtime values to satisfy types; restore
the original behavior instead (verified against the existing specs):

- row-state: getDefaultRowState message restored to null (was changed to
  undefined); RowState.message typed string | null.
- cf-user roles: createUserRoleInOrg/InSpace args made optional so an
  unset role stays undefined (was changed to false, which the role-change
  diff would treat as an explicit removal). Restored undefined defaults.
- auth-data: applySessionScopes is called unconditionally again (it
  no-ops on an absent user); widened its param to SessionUser | undefined.
  A guard had stopped it firing when the verified session carried no user.
- deploy-app wizard: kept the idiomatic undefined for the initial unset
  applicationSource/sourceType (functionally identical to the old null for
  these optional fields — every consumer uses ?./filter(!!x)); updated the
  two spec assertions that encoded the ngrx-era null.

Verified: ng build clean; store + cloud-foundry + core test projects all
green (2204 tests, 0 failures).

Author: nabramovitz

src/frontend/packages/cloud-foundry/src/services/domain-data/cf-deploy-app-data.service.spec.ts

@@ -26,8 +26,9 @@ describe('CfDeployAppDataService', () => {
 
   it('starts with the default empty wizard state', () => {
     expect(svc.cfDetails()).toBeNull();
-    expect(svc.sourceType()).toBeNull();
-    expect(svc.applicationSource()).toEqual({ type: null });
+    // Optional wizard fields start unset (undefined) until the user picks a source.
+    expect(svc.sourceType()).toBeUndefined();
+    expect(svc.applicationSource()).toBeUndefined();
     expect(svc.projectExists()).toEqual({ checking: false, exists: false, error: false, name: '' });
   });
 
@@ -52,7 +53,7 @@ describe('CfDeployAppDataService', () => {
     svc.setCfDetails({ cloudFoundry: 'cf-1', org: 'org-1', space: 'space-1' });
     svc.resetState();
     expect(svc.cfDetails()).toBeNull();
-    expect(svc.sourceType()).toBeNull();
+    expect(svc.sourceType()).toBeUndefined();
   });
 
   // The legacy CheckProjectExists action + DeployAppEffects pipeline is

src/frontend/packages/cloud-foundry/src/services/domain-data/cf-users-roles-data.service.ts

@@ -333,7 +333,7 @@ export function createDefaultOrgRoles(orgGuid: string, orgName: string): IUserPe
   return {
     name: orgName,
     orgGuid,
-    permissions: createUserRoleInOrg(false, false, false, false),
+    permissions: createUserRoleInOrg(undefined, undefined, undefined, undefined),
     spaces: {},
   };
 }
@@ -344,7 +344,7 @@ export function createDefaultSpaceRoles(orgGuid: string, orgName: string, spaceG
     spaceGuid,
     orgGuid,
     orgName,
-    permissions: createUserRoleInSpace(false, false, false),
+    permissions: createUserRoleInSpace(undefined, undefined, undefined),
   };
 }
 

src/frontend/packages/cloud-foundry/src/store/types/cf-user.types.ts

@@ -96,8 +96,12 @@ export class UserRoleInOrg {
  * UserRoleInOrg, thus can create roles without this workaround function. See
  * https://github.com/Microsoft/TypeScript/wiki/What%27s-new-in-TypeScript#constant-named-properties for details
  */
-export function createUserRoleInOrg(manager: boolean, billingManager: boolean, auditor: boolean, user: boolean): UserRoleInOrg {
-  const res = {} as Record<OrgUserRoleNames, boolean>;
+export function createUserRoleInOrg(
+  manager?: boolean, billingManager?: boolean, auditor?: boolean, user?: boolean
+): UserRoleInOrg {
+  // Args are optional: an unset role stays `undefined` (distinct from an
+  // explicit `false`, which the role-change diff would treat as a removal).
+  const res = {} as Record<OrgUserRoleNames, boolean | undefined>;
   res[OrgUserRoleNames.MANAGER] = manager;
   res[OrgUserRoleNames.BILLING_MANAGERS] = billingManager;
   res[OrgUserRoleNames.AUDITOR] = auditor;
@@ -143,8 +147,10 @@ export interface UserRoleInSpace {
  * https://github.com/Microsoft/TypeScript/wiki/What%27s-new-in-TypeScript#constant-named-properties for details
  *
  */
-export function createUserRoleInSpace(manager: boolean, auditor: boolean, developer: boolean): UserRoleInSpace {
-  const res = {} as Record<SpaceUserRoleNames, boolean>;
+export function createUserRoleInSpace(manager?: boolean, auditor?: boolean, developer?: boolean): UserRoleInSpace {
+  // Args are optional: an unset role stays `undefined` (distinct from an
+  // explicit `false`, which the role-change diff would treat as a removal).
+  const res = {} as Record<SpaceUserRoleNames, boolean | undefined>;
   res[SpaceUserRoleNames.MANAGER] = manager;
   res[SpaceUserRoleNames.DEVELOPER] = developer;
   res[SpaceUserRoleNames.AUDITOR] = auditor;

src/frontend/packages/core/src/shared/components/signal-list/row-state.types.ts

@@ -5,7 +5,7 @@ export interface RowsState {
 export interface RowState {
   busy?: boolean;
   error?: boolean;
-  message?: string;
+  message?: string | null;
   blocked?: boolean;
   highlighted?: boolean;
   deleting?: boolean;
@@ -19,5 +19,5 @@ export const getDefaultRowState = (): RowState => ({
   error: false,
   blocked: false,
   deleting: false,
-  message: undefined
+  message: null
 });

src/frontend/packages/store/src/services/auth-data.service.ts

@@ -247,11 +247,9 @@ export class AuthDataService {
     // signal source of truth (replaces the former SESSION_VERIFIED reducer
     // case). CF endpoint admin scopes are propagated separately by
     // CfEndpointRoleSyncService observing the sessionData signal.
-    // applySessionScopes no-ops on an absent user; guard here so the optional
-    // sessionData.user matches the collaborator's required param.
-    if (sessionData.user) {
-      this.rolesData.applySessionScopes(sessionData.user);
-    }
+    // applySessionScopes accepts an absent user (it no-ops internally); call
+    // it unconditionally so verification always feeds the roles slice.
+    this.rolesData.applySessionScopes(sessionData.user);
     this.patch({
       error: false,
       errorResponse: '',

src/frontend/packages/store/src/services/current-user-roles-data.service.ts

@@ -70,7 +70,7 @@ export class CurrentUserRolesDataService {
    * the reducer's `CURRENT_USER_ROLES_SESSION_VERIFIED` case
    * (`applyInternalScopes`). No-op on internal roles when `user` is absent.
    */
-  applySessionScopes(user: SessionUser): void {
+  applySessionScopes(user: SessionUser | undefined): void {
     if (!user) {
       return;
     }