fix(jetstream): surface close error on unarchive open-failure path#5635
Merged
norman-abramovitz merged 1 commit intoJul 13, 2026
Merged
Conversation
The entry.Open error path discarded out.Close()'s error, leaving the last go/unhandled-writable-file-close Code Quality warning. Join the close error with the open error instead of dropping it.
norman-abramovitz
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the last open Code Quality warning (go/unhandled-writable-file-close, unarchive.go).
The entry.Open error path in cfapppush's unarchive discarded the error from out.Close(). Now the close error is joined with the open error via errors.Join, so a failed close is surfaced instead of silently dropped while the more significant open failure still leads the chain.
Verified: cfapppush build and tests pass, make lint clean on both modules, full check gate green.