Skip to content

fix(jetstream): surface close error on unarchive open-failure path #5635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norman-abramovitz merged 1 commit into from
Jul 13, 2026
+4 −2
Merged

fix(jetstream): surface close error on unarchive open-failure path #5635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/jetstream/plugins/cfapppush/unarchive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package cfapppush

import (
"context"
"errors"
"fmt"
"io"
"os"
Expand Down Expand Up @@ -64,8 +65,9 @@ func unarchive(src, dst string) error {
}
in, err := entry.Open()
if err != nil {
out.Close()
return err
// Join rather than drop the close error - the open failure
// matters more, but a failed close is still worth surfacing
return errors.Join(err, out.Close())
}
defer in.Close()
_, err = io.Copy(out, in)
Expand Down
Loading