Remove styling-harvest instrumentation attributes from templates#5637
Merged
norman-abramovitz merged 2 commits intoJul 14, 2026
Merged
Conversation
Strip the stb-snapshot-id / stba-* attributes from the login page, confirm dialog, stepper and app wall. The DOM-harvest experiment they served is superseded; component intent now lives in the declared styling contract, not in DOM attributes. Every element with real accessibility value already carries a native role (alert, note, status), so nothing converts to aria-*. Login spec selectors move to the stable ids/classes and the instrumentation-only describe block is deleted. repo: cf-stratos
Contributor
|
Changing how Stratos is styled and cleaning up the integration points. |
The harvest lint (login template <-> routing.json) and the shared-scene template lint existed to protect the correspondence between live Stratos templates and the captured snapshots. With the instrumentation removed from the live templates that correspondence is deliberately severed, so both lints retire: lint-templates.ts deleted, the lint:harvest / lint:templates scripts dropped, the two CI steps removed, and the template paths dropped from the workflow's change filter. harvest-login.ts stays: generate-model.ts still harvests the frozen snapshot DOM, and the parser has its own unit tests. repo: cf-stratos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
stb-snapshot-id/stba-*attributes that were added to the login page, confirm dialog, stepper and application wall to instrument the DOM for a styling-model harvesting experiment. That experiment has concluded and the attributes have no remaining consumer, so they are dead markup in production templates.Notes on scope:
aria-*because every element whose instrumentation described real accessibility semantics already carries a native role (role="alert"on the login error banner,role="note"on the login notice,role="status"on the app-wall loading indicator). The remaining descriptions were styling wording with no accessibility value.stb-snapshot-id; those selectors now use the stable ids/classes (#login-error-message,.login-card,.login-logo,.login-title,.login-message). One describe block existed solely to assert the instrumentation was present; it is deleted with the instrumentation.Gate: lint, full frontend unit suite (3117 passing) and production build, plus the jetstream Go tests — all green.
Follow-up commit: the theme-builder's live-template drift lints (
lint:harvest,lint:templates) existed to protect the template-to-snapshot correspondence this PR severs, so they retire with the instrumentation — CI steps and the workflow's template path filters removed.harvest-login.tsstays: the model generator still harvests the frozen snapshot DOM, and the parser keeps its unit tests (601 stb tests green).