Fix authorization code consumption - #4006
Open
joemahady-comm wants to merge 1 commit into
Open
Conversation
…-delete-rowcount-toctou / uaa ai-assisted=yes Co-authored-by: Cursor <cursoragent@cursor.com>
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
joemahady-comm
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens authorization code consumption in UaaTokenStore to prevent TOCTOU-style races that could otherwise allow more than one access token to be minted from a single authorization code.
Changes:
- Delete the authorization code row before deserializing/returning the stored authentication (so the code can’t be reused if another consumer races).
- Add a delete row-count check to detect “code already consumed” scenarios.
Comment on lines
+146
to
+150
| int deletedRows = template.update(SQL_DELETE_STATEMENT, code); | ||
| if (deletedRows == 0) { | ||
| throw new InvalidGrantException("Invalid authorization code: " + code); | ||
| } | ||
|
|
Comment on lines
+146
to
+151
| int deletedRows = template.update(SQL_DELETE_STATEMENT, code); | ||
| if (deletedRows == 0) { | ||
| throw new InvalidGrantException("Invalid authorization code: " + code); | ||
| } | ||
|
|
||
| if (tokenCode.isExpired()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: authorization-code-consumption-ignores-delete-rowcount-toctou
Fix: Validated that JdbcTemplate.update deletes exactly 1 row when consuming an authorization code, preventing TOCTOU races resulting in multiple access tokens per single code.