Skip to content

Fix bcrypt timing #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joemahady-comm wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −0
Open

Fix bcrypt timing #4007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...java/org/cloudfoundry/identity/uaa/authentication/manager/AuthzAuthenticationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
import java.util.Locale;

public class AuthzAuthenticationManager implements AuthenticationManager, ApplicationEventPublisherAware {
private static final String DUMMY_BCRYPT_HASH = "{bcrypt}$2a$10$xn3igMIdgceZX.mK6/0.n.MvJk1.L/0R15Tz3gGZ/7eM/T.xI.1wO";

Comment on lines +43 to +44
private final HttpSession httpSession;
private final SanitizedLogFactory.SanitizedLog logger = SanitizedLogFactory.getLog(getClass());
private final PasswordEncoder encoder;
Expand Down Expand Up @@ -74,6 +76,9 @@ public Authentication authenticate(Authentication req) throws AuthenticationExce
UaaUser user = getUaaUser(req);

if (user == null) {
if (((CharSequence) req.getCredentials()).length() != 0) {
encoder.matches((CharSequence) req.getCredentials(), DUMMY_BCRYPT_HASH);
}
Comment on lines 78 to +81
logger.debug("No user named '" + req.getName() + "' was found for origin:" + origin);
publish(new UserNotFoundEvent(req, IdentityZoneHolder.getCurrentZoneId()));
} else {
Expand Down
Loading