Skip to content

fix: remove aria-live from volumeBar #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsi merged 1 commit into from
Mar 16, 2026
Merged

fix: remove aria-live from volumeBar #1002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/video-player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ class VideoPlayer {

this.videojs.ready(() => {
this._onReady();
this._applyVolumeBarAriaLiveFix();

if (ready) {
ready(this);
Expand Down Expand Up @@ -581,6 +582,17 @@ class VideoPlayer {
}
}

/**
* Temporary fix: remove aria-live from VolumeBar to avoid NVDA repeated announcements.
* TODO: Remove when Video.js includes the upstream fix (nvaccess/nvda#7996).
*/
_applyVolumeBarAriaLiveFix() {
const volumeBar = this.videojs.$('.vjs-volume-bar');
if (volumeBar) {
volumeBar.removeAttribute('aria-live');
}
}

_onSourceChange(e, { source, sourceOptions }) {
this._sendInternalAnalytics({ ...(sourceOptions && { sourceOptions }) });
this.isLiveStream = source?.resourceConfig()?.type === 'live';
Expand Down
Loading