Skip to content

test(video-20810): smoke test for profiles and config applet#1033

Merged
ShayLevi merged 5 commits into
masterfrom
video-20810-smoke-tests-for-profiles-and-config
Apr 26, 2026
Merged

test(video-20810): smoke test for profiles and config applet#1033
ShayLevi merged 5 commits into
masterfrom
video-20810-smoke-tests-for-profiles-and-config

Conversation

@ShayLevi
Copy link
Copy Markdown
Contributor

@ShayLevi ShayLevi commented Apr 20, 2026

This PR improves E2E coverage for applet-based profile/config fetching and color application on the Profiles page.

What changed

  • Added validateColors to VideoComponent (test/e2e/components/videoComponent.ts) to validate player theme CSS custom properties (--color-base, --color-accent, --color-text) via the .cld-video-player wrapper.
  • Two shared common-spec helpers:
    • test/e2e/specs/commonSpecs/profilesAndConfigAppletFetch.ts
    • test/e2e/specs/commonSpecs/profilesAndConfigAppletMockedColors.ts
  • Added two specs:
    • test/e2e/specs/NonESM/profilesAndConfigAppletFetch.spec.ts
    • test/e2e/specs/NonESM/profileAndConfigAppletMockedColor.spec.ts
  • Extracted applet route patterns into a shared constants file:
    • test/e2e/src/consts/appletRoutes.ts

Why

  • Reduces false positives by validating endpoint URL shape instead of loose substring checks.
  • Verifies both applet fetch paths (profile + config) and their downstream visual config effect in one coherent E2E scenario.
  • Reuses a POM-level color assertion method to keep tests cleaner and easier to extend.

@ShayLevi ShayLevi requested a review from a team as a code owner April 20, 2026 05:52
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 20, 2026

Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit 1ab5935
🔍 Latest deploy log https://app.netlify.com/projects/cld-video-player/deploys/69edeffad8b969000872df0a
😎 Deploy Preview https://deploy-preview-1033--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 20, 2026

Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit 1ab5935
🔍 Latest deploy log https://app.netlify.com/projects/cld-vp-esm-pages/deploys/69edeffa2cccd200084434f3
😎 Deploy Preview https://deploy-preview-1033--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ShayLevi ShayLevi requested a review from refael-m April 20, 2026 06:04
Copy link
Copy Markdown
Collaborator

@tsi tsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ShayLevi ShayLevi merged commit 244950e into master Apr 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants