Merged
Conversation
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kalifyaniv-cloudinary
approved these changes
Apr 7, 2025
|
|
||
| // Add keyboard support | ||
| markerEl.addEventListener('keydown', e => { | ||
| if (e.key === 'Enter' || e.key === ' ') { |
Collaborator
Author
There was a problem hiding this comment.
We could do e.code === 'Space' which is more semantically clear, but AFAIU for assistive technology devices that aren't standard keyboards, e.key will give better support because it represents the semantic meaning of the input ("space") and not necessarily the space-key itself.
This was referenced Dec 10, 2025
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves a few aspects of using the visual-search plugin with a keyboard.