feat: live streams analytics#862
Merged
Merged
Conversation
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kalifyaniv-cloudinary
approved these changes
May 12, 2025
Contributor
kalifyaniv-cloudinary
left a comment
kalifyaniv-cloudinary
left a comment
There was a problem hiding this comment.
Please check my second comment before merging...
Comment on lines
+50
to
+78
| return { | ||
| onCanPlay: (callback) => createCldVPEventListener('canplay', callback), | ||
| onCanPlayThrough: (callback) => createCldVPEventListener('canplaythrough', callback), | ||
| onComplete: (callback) => createCldVPEventListener('complete', callback), | ||
| onDurationChange: (callback) => createCldVPEventListener('durationchange', callback), | ||
| onEmptied: (callback) => createCldVPEventListener('emptied', callback), | ||
| onEnded: (callback) => createCldVPEventListener('ended', callback), | ||
| onError: (callback) => createCldVPEventListener('error', callback), | ||
| onLoadedData: (callback) => createCldVPEventListener('loadeddata', callback), | ||
| onLoadedMetadata: (callback) => createCldVPEventListener('loadedmetadata', callback), | ||
| onLoadStart: (callback) => createCldVPEventListener('loadstart', callback), | ||
| onPause: (callback) => createCldVPEventListener('pause', callback), | ||
| onPlay: (callback) => createCldVPEventListener('play', callback), | ||
| onPlaying: (callback) => createCldVPEventListener('playing', callback), | ||
| onProgress: (callback) => createCldVPEventListener('progress', callback), | ||
| onRateChange: (callback) => createCldVPEventListener('ratechange', callback), | ||
| onSeeked: (callback) => createCldVPEventListener('seeked', callback), | ||
| onSeeking: (callback) => createCldVPEventListener('seeking', callback), | ||
| onStalled: (callback) => createCldVPEventListener('stalled', callback), | ||
| onSuspend: (callback) => createCldVPEventListener('suspend', callback), | ||
| onTimeUpdate: (callback) => createCldVPEventListener('timeupdate', callback), | ||
| onVolumeChange: (callback) => createCldVPEventListener('volumechange', callback), | ||
| onWaiting: (callback) => createCldVPEventListener('waiting', callback), | ||
|
|
||
| getCurrentSrc: () => this.player.videoElement.currentSrc, | ||
| getCurrentTime: () => this.player.currentTime(), | ||
| getReadyState: () => this.player.videoElement.readyState, | ||
| getDuration: () => this.player.duration(), | ||
| }; |
Contributor
There was a problem hiding this comment.
does this mean we added more events to the "regular" tracking also?
Contributor
Author
There was a problem hiding this comment.
for now - no, I just created mapping for all events, it doesn't mean we are listening for all of them, it just means that we can start listening whenever we want to ( thats schema of required props as player adapter )
Comment on lines
-59
to
-63
| // only for iOS there is problem with reporting events because videojs re-triggers events and stops native ones | ||
| if (this.shouldUseCustomEvents) { | ||
| this.connectCustomEvents(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
why did we remove this?
Contributor
Author
There was a problem hiding this comment.
analytics package was listening for custom event that was triggered by videojs to resolve issue with one event that was actually prevent from bubbling on videojs side for iOS
with new player adapter mechanism its videojs responsibility to trigger events in right moment - so there is no browser-specific or device-specific case as its being handled internally by library
This was referenced Dec 10, 2025
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new version of video analytics: