Skip to content

Commit 49d1a3a

Browse files
authored
Fix missing userAgent error on nodejs (#281)
1 parent 5b689e5 commit 49d1a3a

1 file changed

Lines changed: 15 additions & 6 deletions

File tree

src/util/browser.js

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,31 +3,39 @@
33
* https://github.com/videojs/video.js/blob/4238f5c1d88890547153e7e1de7bd0d1d8e0b236/src/js/utils/browser.js
44
*/
55

6-
// User agent example taken from Safari desktop:
7-
const useAgent = navigator && navigator.userAgent || '';
6+
/**
7+
* Retrieve from the navigator the user agent property.
8+
* @returns user agent property.
9+
*/
10+
function getUserAgent(){
11+
return navigator && navigator.userAgent || '';
12+
}
813

914
/**
1015
* Detect if current browser is any Android
1116
* @returns true if current browser is Android, false otherwise.
1217
*/
1318
export function isAndroid(){
14-
return (/Android/i).test(useAgent);
19+
const userAgent = getUserAgent();
20+
return (/Android/i).test(userAgent);
1521
}
1622

1723
/**
1824
* Detect if current browser is any Edge
1925
* @returns true if current browser is Edge, false otherwise.
2026
*/
2127
export function isEdge(){
22-
return (/Edg/i).test(useAgent);
28+
const userAgent = getUserAgent();
29+
return (/Edg/i).test(userAgent);
2330
}
2431

2532
/**
2633
* Detect if current browser is chrome.
2734
* @returns true if current browser is Chrome, false otherwise.
2835
*/
2936
export function isChrome(){
30-
return !isEdge() && ((/Chrome/i).test(useAgent) || (/CriOS/i).test(useAgent));
37+
const userAgent = getUserAgent();
38+
return !isEdge() && ((/Chrome/i).test(userAgent) || (/CriOS/i).test(userAgent));
3139
}
3240

3341
/**
@@ -38,5 +46,6 @@ export function isSafari(){
3846
// User agents for other browsers might include "Safari" so we must exclude them.
3947
// For example - this is the chrome user agent on windows 10:
4048
// Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36
41-
return (/Safari/i).test(useAgent) && !isChrome() && !isAndroid() && !isEdge();
49+
const userAgent = getUserAgent();
50+
return (/Safari/i).test(userAgent) && !isChrome() && !isAndroid() && !isEdge();
4251
}

0 commit comments

Comments
 (0)