Merge pull request #1148 from cloudinary/remove-php-warning

gabrielcld2 · web-flow · commit 506feb9b1c3c · 2026-02-12T15:44:52.000+01:00
Fix PHP warning on is_cloudinary_url method
diff --git a/php/class-media.php b/php/class-media.php
@@ -1981,7 +1981,7 @@ public function is_cloudinary_url( $url ) {
 		$test_parts = wp_parse_url( $url );
 		$cld_url    = wp_parse_url( $this->base_url, PHP_URL_HOST );
 
-		return isset( $test_parts['path'] ) && false !== strpos( $test_parts['host'], $cld_url );
+		return isset( $test_parts['path'], $test_parts['host'] ) && false !== strpos( $test_parts['host'], $cld_url );
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -1981,7 +1981,7 @@ public function is_cloudinary_url( $url ) {`
`1981`	`1981`	`$test_parts = wp_parse_url( $url );`
`1982`	`1982`	`$cld_url = wp_parse_url( $this->base_url, PHP_URL_HOST );`
`1983`	`1983`
`1984`		`- return isset( $test_parts['path'] ) && false !== strpos( $test_parts['host'], $cld_url );`
	`1984`	`+ return isset( $test_parts['path'], $test_parts['host'] ) && false !== strpos( $test_parts['host'], $cld_url );`
`1985`	`1985`	`}`
`1986`	`1986`
`1987`	`1987`	`/**`