Fix CSS & JS deprecation warnings following node upgrade#1160
Merged
gabrielcld2 merged 6 commits intodevelopfrom Apr 6, 2026
Merged
Fix CSS & JS deprecation warnings following node upgrade#1160gabrielcld2 merged 6 commits intodevelopfrom
gabrielcld2 merged 6 commits intodevelopfrom
Conversation
PatelUtkarsh
approved these changes
Apr 2, 2026
PatelUtkarsh
left a comment
There was a problem hiding this comment.
LGTM!
Build is clean, all Sass warnings are gone. Tested locally and everything looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the recent node upgrade, several deprecation warnings were being shown.
These are now addressed here.
Approach
renderwithcreateRoot@importto either@useor@forwardNote: there are two warnings left due to file sizes. These might have to remain for now:
syntax-highlight.jsis large due to the CodeMirror dependency. That file is thankfully only enqueued on the admin page requiring it only, so perhaps we can leave with this for now.QA notes
npm run buildto make sure assets are still building and not showing warnings (except for the two file sizes mentioned above)